| Summary: | Remove C4::Dates from files acqui/pdfformat/layout*.pm | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marc Véron <veron> |
| Component: | Architecture, internals, and plumbing | Assignee: | Marc Véron <veron> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | hector.hecaxmmx, jonathan.druart, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 14870 | ||
| Attachments: |
Bug 14928 - Remove C4::Dates from files acqui/pdfformat/layout*.pm
[COUNTER-PATCH] Bug 14928: Remove C4::Dates from circ/pendingreserves.pl [SIGNED-OFF]Bug 14928 - Remove C4::Dates from files acqui/pdfformat/layout*.pm Bug 14928 - Remove C4::Dates from files acqui/pdfformat/layout*.pm |
||
|
Description
Marc Véron
2015-09-30 13:56:40 UTC
Created attachment 42975 [details] [review] Bug 14928 - Remove C4::Dates from files acqui/pdfformat/layout*.pm This patch removes C4::Dates from: - acqui/pdfformat/layout2pages.pm - acqui/pdfformat/layout2pagesde.pm - acqui/pdfformat/layout3pages.pm - acqui/pdfformat/layout3pagesfr.pm To test: - Apply patch - Go to Home > Acquisitions > [Vendor] > Basket groups - Print a basket (order) - Verify that the current date is formatted respects syspref 'dateformat' - Do the same with syspref 'OrderPdfFormat' set to the four different choices Created attachment 42991 [details] [review] [COUNTER-PATCH] Bug 14928: Remove C4::Dates from circ/pendingreserves.pl This patch uses Koha::DateUtils instead of C4::Dates and Date::Calc. It also sent DateTime objects to the template, which use the TT plugin to display them. If an invalid dates is entered, the default date is picked. Test plan: 1/ Go to Home > Circulation > Holds to pull 2/ Verify that the the filter and the list behave as before 3/ Enter invalid dates and confirm that you do not get a software error Wrong bug report, sorry about that. Created attachment 43286 [details] [review] [SIGNED-OFF]Bug 14928 - Remove C4::Dates from files acqui/pdfformat/layout*.pm This patch removes C4::Dates from: - acqui/pdfformat/layout2pages.pm - acqui/pdfformat/layout2pagesde.pm - acqui/pdfformat/layout3pages.pm - acqui/pdfformat/layout3pagesfr.pm To test: - Apply patch - Go to Home > Acquisitions > [Vendor] > Basket groups - Print a basket (order) - Verify that the current date is formatted respects syspref 'dateformat' - Do the same with syspref 'OrderPdfFormat' set to the four different choices Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Date printed in PDF Ok Created attachment 43291 [details] [review] Bug 14928 - Remove C4::Dates from files acqui/pdfformat/layout*.pm This patch removes C4::Dates from: - acqui/pdfformat/layout2pages.pm - acqui/pdfformat/layout2pagesde.pm - acqui/pdfformat/layout3pages.pm - acqui/pdfformat/layout3pagesfr.pm To test: - Apply patch - Go to Home > Acquisitions > [Vendor] > Basket groups - Print a basket (order) - Verify that the current date is formatted respects syspref 'dateformat' - Do the same with syspref 'OrderPdfFormat' set to the four different choices Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Date printed in PDF Ok Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Patch pushed to master. Thanks Marc! |