| Summary: | "Show more" link contains double encoded characters | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Templates | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | f.demians, joonas.kylmala, koha, tomascohen, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 13789 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 14955: Don't double encode chars in the "Show more" link
Bug 14955: Don't double encode chars in the "Show more" link Bug 14955: Don't double encode chars in the "Show more" link [PASSED QA] Bug 14955: Don't double encode chars in the "Show more" link |
||
|
Description
Jonathan Druart
2015-10-05 10:17:08 UTC
Created attachment 43117 [details] [review] Bug 14955: Don't double encode chars in the "Show more" link Bug 13789 has fixed this issue for the facet links (select/unselect) but not for the "Show more" facets link. This patch reuses the "url" variable, generated for the facets, for these links. A new "local_url" variable is used to build links for each entry. Test plan (for OPAC and intranet): - Search for a very common term - Filter the results using facets - You should get more than 5 entries for a facet and 1 selected: Author author 1 author 2 [x] # Selected author 3 author 4 author 5 Show more # you see this link if there is 5+ values for this facet - Click on the Show more link Without this patch, the url contains double-encoded characters and you will certainly don't get any results With this patch, you should get results. After doing the test plan you can't remove the filter item (author). If you click the |x| it will stay still there (and if you try again, it will just stay there....). I have retried and it works here. What is the url for the [x] link? (In reply to Jonathan Druart from comment #3) > I have retried and it works here. > What is the url for the [x] link? http://10.0.3.132/cgi-bin/koha/opac-search.pl?idx=kw&q=a&limit=au%3AHurme-Ker%C3%A4nen%2C%20Auli.&sort_by=relevance_dsc Created attachment 43382 [details] [review] Bug 14955: Don't double encode chars in the "Show more" link Bug 13789 has fixed this issue for the facet links (select/unselect) but not for the "Show more" facets link. This patch reuses the "url" variable, generated for the facets, for these links. A new "local_url" variable is used to build links for each entry. Test plan (for OPAC and intranet): - Search for a very common term - Filter the results using facets - You should get more than 5 entries for a facet and 1 selected: Author author 1 author 2 [x] # Selected author 3 author 4 author 5 Show more # you see this link if there is 5+ values for this facet - Click on the Show more link Without this patch, the url contains double-encoded characters and you will certainly don't get any results With this patch, you should get results. Indeed, it worked for the intranet, not for the OPAC. Encoding issue at the OPAC on a stable version, I am raising the severity to major. Created attachment 44110 [details] [review] Bug 14955: Don't double encode chars in the "Show more" link Bug 13789 has fixed this issue for the facet links (select/unselect) but not for the "Show more" facets link. This patch reuses the "url" variable, generated for the facets, for these links. A new "local_url" variable is used to build links for each entry. Test plan (for OPAC and intranet): - Search for a very common term - Filter the results using facets - You should get more than 5 entries for a facet and 1 selected: Author author 1 author 2 [x] # Selected author 3 author 4 author 5 Show more # you see this link if there is 5+ values for this facet - Click on the Show more link Without this patch, the url contains double-encoded characters and you will certainly don't get any results With this patch, you should get results. Signed-off-by: Marc Véron <veron@veron.ch> I am failing to reproduce the problem - not sure what I am missing :( Katrin, I haven't test as explained by Jonathan but I have a similar problem : You perform a search with several pages of results. You go on the second page, click on "show more" the URL contains space characters (I don't really know what sort of characters..) and if you click you don't have any result. Sonia I try Jonathan's patch. I confirm that it solves the problem described on the "show more" link (bad characters in the URL). But for me, the problem occurs only from the second page of results and it's not related to the fact of having a facet already selected. The problem exists whatever you have already selected a facet or not. Created attachment 44454 [details] [review] [PASSED QA] Bug 14955: Don't double encode chars in the "Show more" link Bug 13789 has fixed this issue for the facet links (select/unselect) but not for the "Show more" facets link. This patch reuses the "url" variable, generated for the facets, for these links. A new "local_url" variable is used to build links for each entry. Test plan (for OPAC and intranet): - Search for a very common term - Filter the results using facets - You should get more than 5 entries for a facet and 1 selected: Author author 1 author 2 [x] # Selected author 3 author 4 author 5 Show more # you see this link if there is 5+ values for this facet - Click on the Show more link Without this patch, the url contains double-encoded characters and you will certainly don't get any results With this patch, you should get results. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> I still have a bit of a problem reproducing the issue, but I can verify the change in the URL now and things seem to work like they should. Also trusting the other testers here. Patch pushed to master. Thanks Jonathan! This patch has been pushed to 3.20.x, will be in 3.20.6. |