|
Description
Marc Véron
2015-10-05 16:20:41 UTC
Created attachment 43149 [details] [review] Bug 14960 - Remove C4::Dates from files in misc/cronjobs (part 1) This patch removes C4::Dates from following files: - misc/cronjobs/batch_anonymise.pl - misc/cronjobs/cleanup_database.pl - misc/cronjobs/gather_print_notices.pl - misc/cronjobs/serialsUpdate.pl - misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl To test: - Carefully review code changes. - Verify that the cronjobs behave as before. Created attachment 43310 [details] [review] Bug 14960 - Remove C4::Dates from files in misc/cronjobs This patch removes C4::Dates from following files: - misc/cronjobs/batch_anonymise.pl - misc/cronjobs/cleanup_database.pl - misc/cronjobs/gather_print_notices.pl - misc/cronjobs/serialsUpdate.pl - misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl - misc/cronjobs/overdue_notices.pl - misc/cronjobs/staticfines.pl To test: - Carefully review code changes. - Verify that the cronjobs behave as before. Still applies Still applies. Created attachment 44440 [details] [review] Bug 14960 - Remove C4::Dates from files in misc/cronjobs This patch removes C4::Dates from following files: - misc/cronjobs/batch_anonymise.pl - misc/cronjobs/cleanup_database.pl - misc/cronjobs/gather_print_notices.pl - misc/cronjobs/serialsUpdate.pl - misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl - misc/cronjobs/overdue_notices.pl - misc/cronjobs/staticfines.pl To test: - Carefully review code changes. - Verify that the cronjobs behave as before. Amended to make patch apply ( 04.11.2015 / mv :-) ) Marc, this bug cover also misc/cronjobs/overdue_notices.pl and misc/cronjobs/staticfines.pl ? Because I see modification also on those two scripts. (In reply to Zeno Tajoli from comment #6) > Marc, this bug cover also misc/cronjobs/overdue_notices.pl and > misc/cronjobs/staticfines.pl ? > Because I see modification also on those two scripts. Yes, as mentioned in teh latest commit message. Marc Joonas, are you working on this bug? It was assigned to you since this morning. Comment on attachment 44440 [details] [review] Bug 14960 - Remove C4::Dates from files in misc/cronjobs Hmm, something is wrong with the latest patch when I amended to make it apply. Going back... Comment on attachment 43310 [details] [review] Bug 14960 - Remove C4::Dates from files in misc/cronjobs Reactivating... Created attachment 44563 [details] [review] Bug 14960 - Remove C4::Dates from files in misc/cronjobs This patch removes C4::Dates from following files: - misc/cronjobs/batch_anonymise.pl - misc/cronjobs/cleanup_database.pl - misc/cronjobs/gather_print_notices.pl - misc/cronjobs/serialsUpdate.pl - misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl - misc/cronjobs/overdue_notices.pl - misc/cronjobs/staticfines.pl To test: - Carefully review code changes. - Verify that the cronjobs behave as before. Amended to make patch apply and follwoing comments on IRC by putti http://irc.koha-community.org/koha/2015-11-06#i_1752803 (misc/cronjobs/gather_print_notices.pl is using still C4::Dates, line 84) 6.11.2015 /mv Eyeballs well. Have yet to test it. Created attachment 44611 [details] [review] [SIGNED-OFF] Remove C4 Dates from files in misc/cronjob Zeno: you forgot to set the bug to "signed off" Sorry, I forgot to change the status (In reply to M. Tompsett from comment #12) > Eyeballs well. Have yet to test it. I can say also that the code looks good. Haven't ran the scripts thoroughly, though. Created attachment 44742 [details] [review] Bug 14960 - Remove C4::Dates from files in misc/cronjobs This patch removes C4::Dates from following files: - misc/cronjobs/batch_anonymise.pl - misc/cronjobs/cleanup_database.pl - misc/cronjobs/gather_print_notices.pl - misc/cronjobs/serialsUpdate.pl - misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl - misc/cronjobs/overdue_notices.pl - misc/cronjobs/staticfines.pl To test: - Carefully review code changes. - Verify that the cronjobs behave as before. Amended to make patch apply and follwoing comments on IRC by putti http://irc.koha-community.org/koha/2015-11-06#i_1752803 (misc/cronjobs/gather_print_notices.pl is using still C4::Dates, line 84) 6.11.2015 /mv Signed-off-by: Zeno Tajoli <z.tajoli@cineca.it> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 44743 [details] [review] Bug 14960: Simplify the date management in staticfines There is no need to create a DT objcet, then display in string/iso then recreate a DT object from this string. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 44927 [details] [review] [PASSED QA] Bug 14960 - Remove C4::Dates from files in misc/cronjobs This patch removes C4::Dates from following files: - misc/cronjobs/batch_anonymise.pl - misc/cronjobs/cleanup_database.pl - misc/cronjobs/gather_print_notices.pl - misc/cronjobs/serialsUpdate.pl - misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl - misc/cronjobs/overdue_notices.pl - misc/cronjobs/staticfines.pl To test: - Carefully review code changes. - Verify that the cronjobs behave as before. Amended to make patch apply and follwoing comments on IRC by putti http://irc.koha-community.org/koha/2015-11-06#i_1752803 (misc/cronjobs/gather_print_notices.pl is using still C4::Dates, line 84) 6.11.2015 /mv Signed-off-by: Zeno Tajoli <z.tajoli@cineca.it> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 44928 [details] [review] [PASSED QA] Bug 14960: Simplify the date management in staticfines There is no need to create a DT objcet, then display in string/iso then recreate a DT object from this string. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patches pushed to master. Thanks Marc and Jonathan! |