| Summary: | Email notices will be queued for patrons with no email address | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kyle M Hall <kyle.m.hall> |
| Component: | Notices | Assignee: | Kyle M Hall <kyle.m.hall> |
| Status: | In Discussion --- | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | arm, chris, mtompset, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31424 |
||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 14964 - Email notices will be queued for patrons with no email address
Bug 14964 - Email notices will be queued for patrons with no email address |
||
|
Description
Kyle M Hall
2015-10-06 12:30:14 UTC
Created attachment 43161 [details] [review] Bug 14964 - Email notices will be queued for patrons with no email address If a patron has email messaging preferences set but no email address, a message will be added to the message queue anyway, but will always end up 'failed'. This could be resolved by modifying C4::Letters::enqueue to not enqueue call EnqueueLetter if the transport is email or sms and no to address is returned. Test Plan: 1) Set up patron with checkout messaging preference and no email address 2) Check out an item to the patron 3) Note the message in the message queue with no email address 4) Apply this patch 5) Check out an item to the patron 6) Note no message was queued this time Created attachment 43162 [details] [review] Bug 14964 - Email notices will be queued for patrons with no email address If a patron has email messaging preferences set but no email address, a message will be added to the message queue anyway, but will always end up 'failed'. This could be resolved by modifying C4::Letters::enqueue to not enqueue call EnqueueLetter if the transport is email or sms and no to address is returned. Test Plan: 1) Set up patron with checkout messaging preference and no email address 2) Check out an item to the patron 3) Note the message in the message queue with no email address 4) Apply this patch 5) Check out an item to the patron 6) Note no message was queued this time This functionality could be in conflict with: Bug 12426 - Allow resending of emails from the notices tab in the patron account Wondering... should we queue a message of the type 'print' if there is no e-mail address? I think this might be what we do for overdues ... but probably should be configurable - for some notices you might not want to have a printed one I cringe at the lack of test coverage for C4::Message. *sigh* |