| Summary: | Remove C4::Dates: Delete files reservereport.pl / reservereport.tt | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marc Véron <veron> |
| Component: | Architecture, internals, and plumbing | Assignee: | Marc Véron <veron> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | mirko, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 14870 | ||
| Attachments: |
Bug 14995 - Remove C4::Dates: Delete files reservereport.pl / reservereport.tt
Bug 14995 - Remove C4::Dates: Delete files reservereport.pl / reservereport.tt [PASSED QA] Bug 14995 - Remove C4::Dates: Delete files reservereport.pl / reservereport.tt |
||
|
Description
Marc Véron
2015-10-09 19:40:26 UTC
Created attachment 43306 [details] [review] Bug 14995 - Remove C4::Dates: Delete files reservereport.pl / reservereport.tt The following files use C4::Dates, but they seem no longer to be in use: - koha-tmpl/intranet-tmpl/prog/en/modules/reports/reservereport.tt - reports/reservereport.pl To verify: git grep 'reservereport' Still applies Created attachment 43881 [details] [review] Bug 14995 - Remove C4::Dates: Delete files reservereport.pl / reservereport.tt The following files use C4::Dates, but they seem no longer to be in use: - koha-tmpl/intranet-tmpl/prog/en/modules/reports/reservereport.tt - reports/reservereport.pl To verify: git grep 'reservereport' Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> It looks like reservereport got superseeded by reserves_stats.pl and should have been removed some time ago. Not only unused, but appears to be broken as well: Undefined subroutine &main::unfilledreserves called at /home/katrin/kohaclone/reports/reservereport.pl line 74. Created attachment 43933 [details] [review] [PASSED QA] Bug 14995 - Remove C4::Dates: Delete files reservereport.pl / reservereport.tt The following files use C4::Dates, but they seem no longer to be in use: - koha-tmpl/intranet-tmpl/prog/en/modules/reports/reservereport.tt - reports/reservereport.pl To verify: git grep 'reservereport' Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patch pushed to master. Thanks Marc! |