| Summary: | Import patron tool creates 'duplicate' restrictions ( debarments ) | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kyle M Hall <kyle.m.hall> |
| Component: | Patrons | Assignee: | Kyle M Hall <kyle.m.hall> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | f.demians, gmcharlt, janet.mcgowan, kyle.m.hall, liz, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17362 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 15010 - Import patron tool creates 'duplicate' restrictions ( debarments )
[SIGNED-OFF] Bug 15010 - Import patron tool creates 'duplicate' restrictions ( debarments ) Bug 15010 - Import patron tool creates 'duplicate' restrictions ( debarments ) |
||
|
Description
Kyle M Hall
2015-10-14 12:48:21 UTC
Created attachment 43398 [details] [review] Bug 15010 - Import patron tool creates 'duplicate' restrictions ( debarments ) If a patron has restrictions and a CSV file of patrons to be overwritten is uploaded but has no debarred / debarredcomment columns, the a new restriction will be added that combines all the existing restrictions ( i.e. a new debarment based on the existing borrowers.debarred and borrowers.debarredcomment fields ). Test Plan: 1) Create a patron with one or more restrictions 2) Import a CSV file that updates that patron, but with no debarred columns 3) Note a new restrictions is created 4) Delete the new restriction 5) Apply this patch 6) Re-import the CSV file again 7) Note that no new restriction is created 8) Add debarred and debarredcomment columns to the CSV file with a test date and description 9) Re-import the CSV file again 10) Note the new restriction is added to the patron Created attachment 43607 [details] [review] [SIGNED-OFF] Bug 15010 - Import patron tool creates 'duplicate' restrictions ( debarments ) If a patron has restrictions and a CSV file of patrons to be overwritten is uploaded but has no debarred / debarredcomment columns, the a new restriction will be added that combines all the existing restrictions ( i.e. a new debarment based on the existing borrowers.debarred and borrowers.debarredcomment fields ). Test Plan: 1) Create a patron with one or more restrictions 2) Import a CSV file that updates that patron, but with no debarred columns 3) Note a new restrictions is created 4) Delete the new restriction 5) Apply this patch 6) Re-import the CSV file again 7) Note that no new restriction is created 8) Add debarred and debarredcomment columns to the CSV file with a test date and description 9) Re-import the CSV file again 10) Note the new restriction is added to the patron Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Daniel Grobani <dgrobani@samuelmerritt.edu> Created attachment 43977 [details] [review] Bug 15010 - Import patron tool creates 'duplicate' restrictions ( debarments ) If a patron has restrictions and a CSV file of patrons to be overwritten is uploaded but has no debarred / debarredcomment columns, the a new restriction will be added that combines all the existing restrictions ( i.e. a new debarment based on the existing borrowers.debarred and borrowers.debarredcomment fields ). Test Plan: 1) Create a patron with one or more restrictions 2) Import a CSV file that updates that patron, but with no debarred columns 3) Note a new restrictions is created 4) Delete the new restriction 5) Apply this patch 6) Re-import the CSV file again 7) Note that no new restriction is created 8) Add debarred and debarredcomment columns to the CSV file with a test date and description 9) Re-import the CSV file again 10) Note the new restriction is added to the patron Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Daniel Grobani <dgrobani@samuelmerritt.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Patch pushed to master. Thanks Kyle! This patch has been pushed to 3.20.x, will be in 3.20.6. Pushed to 3.18.13, and released. |