Summary: | Tests fail if launched after 23:00 | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Galen Charlton <gmcharlt> |
Severity: | major | ||
Priority: | P5 - low | CC: | chris, liz, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18009 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 18009, 21360 | ||
Attachments: |
Bug 15029: Make the IssueSlip tests pass even if launched after 23:00
Bug 15029: Make the IssueSlip tests pass even if launched after 23:00 [PASSED QA] Bug 15029: Make the IssueSlip tests pass even if launched after 23:00 |
Description
Jonathan Druart
2015-10-19 15:17:24 UTC
Created attachment 43597 [details] [review] Bug 15029: Make the IssueSlip tests pass even if launched after 23:00 Prior to this patch, the tests did not pass if they were launched after 23:00. DateTime complains if you ask for creating a date with hour => 24 (which is logical so far). Test plan: 0/ Don't apply this patch 1/ sudo date -s "2015-10-19 23:50:00";prove t/db_dependent/Members/IssueSlip.t 2/ Apply this patch and repeat 1. Ccing RM & RMaints Created attachment 43629 [details] [review] Bug 15029: Make the IssueSlip tests pass even if launched after 23:00 Prior to this patch, the tests did not pass if they were launched after 23:00. DateTime complains if you ask for creating a date with hour => 24 (which is logical so far). Test plan: 0/ Don't apply this patch 1/ sudo date -s "2015-10-19 23:50:00";prove t/db_dependent/Members/IssueSlip.t 2/ Apply this patch and repeat 1. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 43660 [details] [review] [PASSED QA] Bug 15029: Make the IssueSlip tests pass even if launched after 23:00 Prior to this patch, the tests did not pass if they were launched after 23:00. DateTime complains if you ask for creating a date with hour => 24 (which is logical so far). Test plan: 0/ Don't apply this patch 1/ sudo date -s "2015-10-19 23:50:00";prove t/db_dependent/Members/IssueSlip.t 2/ Apply this patch and repeat 1. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patch pushed to master. Thanks Jonathan! Pushed to 3.20.x will be in 3.20.5 |