| Summary: | Genre/Form-655 URL not clickable in opac-detail.pl, with XSLT enabled | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Mason James <mtj> |
| Component: | OPAC | Assignee: | Mason James <mtj> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | amitddng135, f.demians, hector.hecaxmmx, nick, tomascohen, wsalesky |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 13433 | ||
| Bug Blocks: | 15048 | ||
| Attachments: |
pix, before patch
Bug 15047 - Genre/Form-655 URL not clickable in opac-detail.pl, with XSLT enabled pic, after patch Bug 15047 - 655 URL not clickable in opac-detail. [SIGNED-OFF]Bug 15047: 655 URL not clickable in opac-detail. [PASSED QA] Bug 15047: 655 URL not clickable in opac-detail. |
||
Created attachment 43728 [details] [review] Bug 15047 - Genre/Form-655 URL not clickable in opac-detail.pl, with XSLT enabled to test... 1/ create a 655$a subfield in a bib, with some general info - save bib 2/ view bib in opac-detail.pl - confim genre/form is displayed, but non-clickable :/ 3/ apply patch 4/ confim genre/form is displayed, and *is* clickable :0) Created attachment 43729 [details]
pic, after patch
Created attachment 43767 [details] [review] Bug 15047 - 655 URL not clickable in opac-detail. Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac record details 3) Find or create a record with MARC tags 655 4) Perform an opac search and select records with 655 field, select record and review details page. 5) Check that 655 field is clickable. Comment on attachment 43767 [details] [review] Bug 15047 - 655 URL not clickable in opac-detail. Review of attachment 43767 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl @@ +785,4 @@ > <xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=an:<xsl:value-of select="marc:subfield[@code=9]"/></xsl:attribute> > </xsl:when> > <xsl:when test="$TraceSubjectSubdivisions='1'"> > + <xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=<xsl:call-template name="subfieldSelectSubject"> Why the name change? The two patches conflict, and Mark's question could use an answer (In reply to Nick Clemens from comment #5) > The two patches conflict, I have marked my patch obsolete Sorry for the lack of communication. We actually submitted the patches at nearly the same time. The only difference is my patch uses the named template subfieldSelectSubject not subfieldSelect. The subfieldSelectSubject template was developed to address issues with parentheses in subject searches. The subfieldSelectSubject template strips parentheses from the search string. RE: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13650 Hope that helps clarify. -Winona (In reply to Mason James from comment #6) > (In reply to Nick Clemens from comment #5) > > The two patches conflict, > > I have marked my patch obsolete Created attachment 44977 [details] [review] [SIGNED-OFF]Bug 15047: 655 URL not clickable in opac-detail. Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac record details 3) Find or create a record with MARC tags 655 4) Perform an opac search and select records with 655 field, select record and review details page. 5) Check that 655 field is clickable. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. 655 field clickable Created attachment 44984 [details] [review] [PASSED QA] Bug 15047: 655 URL not clickable in opac-detail. Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac record details 3) Find or create a record with MARC tags 655 4) Perform an opac search and select records with 655 field, select record and review details page. 5) Check that 655 field is clickable. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. 655 field clickable Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patch pushed to master. Thanks Winona! This patch has been pushed to 3.20.x, will be in 3.20.6. |
Created attachment 43726 [details] pix, before patch pix attached