Summary: | Can't add item to rotating collection | ||
---|---|---|---|
Product: | Koha | Reporter: | Josef Moravec <josef.moravec> |
Component: | Tools | Assignee: | Bernardo Gonzalez Kriegel <bgkriegel> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | critical | ||
Priority: | P5 - low | CC: | bgkriegel, f.demians, jonathan.druart, liz, tomascohen, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
rotating collection issue
Steps to reproduce error message (without plack) Bug 15061: Can't add item to rotating collection Bug 15061: Can't add item to rotating collection [PASSED QA] Bug 15061: Can't add item to rotating collection |
Description
Josef Moravec
2015-10-26 11:43:34 UTC
Josef, It looks good here: http://test-intra.plack.bywatersolutions.com/cgi-bin/koha/rotating_collections/addItems.pl Could you please detail your issue? Created attachment 44044 [details]
rotating collection issue
I'm adding a screenshot of the problem I'm facing
I understand now, when I created a new collection, I tried to add items and somehow was redirected on page addItems without colId parameter... so of course adding items failed... Please provide a step by step plan to reproduce, I don't get it. I can't reproduce it now as well... the problem was, I think, that collection ID was lost... but only one way I can reproduce it now is to manually go to address /cgi-bin/koha/rotating_collections/addItems.pl without any parameter... but it's not the way used by normal work.... Created attachment 44287 [details]
Steps to reproduce error message (without plack)
I can reproduce the issue in two steps (without plack):
1) Call /cgi-bin/koha/rotating_collections/addItems.pl without param
Result:
Screen to add items.
Warning in intranet-error.log: Use of unitialized value in string eq
at (...)adItems.pl line 42
Expected result: Should display an error message
2) Try to add an item
Result:
Displays error message:
Failed to add item with barcode XXXX:
NO_ID
See screenshots attached.
See screenshot.
Created attachment 44336 [details] [review] Bug 15061: Can't add item to rotating collection This patch prevents adding items to invalid (empty) rotating collection id To test: 1) Go to /cgi-bin/koha/rotating_collections/addItems.pl 2) Try to add an item, you get error show in attached pictures 3) Apply the patch 4) Go again to /cgi-bin/koha/rotating_collections/addItems.pl 5) Can't add any items I don't know if this is a real problem Created attachment 44337 [details] [review] Bug 15061: Can't add item to rotating collection This patch prevents adding items to invalid (empty) rotating collection id To test: 1) Go to /cgi-bin/koha/rotating_collections/addItems.pl 2) Try to add an item, you get error show in attached pictures 3) Apply the patch 4) Go again to /cgi-bin/koha/rotating_collections/addItems.pl 5) Can't add any items I don't know if this is a real problem Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 44348 [details] [review] [PASSED QA] Bug 15061: Can't add item to rotating collection This patch prevents adding items to invalid (empty) rotating collection id To test: 1) Go to /cgi-bin/koha/rotating_collections/addItems.pl 2) Try to add an item, you get error show in attached pictures 3) Apply the patch 4) Go again to /cgi-bin/koha/rotating_collections/addItems.pl 5) Can't add any items I don't know if this is a real problem Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patch pushed to master. Thanks Bernardo! This patch has been pushed to 3.20.x, will be in 3.20.6. Pushed to 3.18.13, and released. |