Description
Nicole C. Engard
2015-10-27 16:11:41 UTC
Where? Hi Nicole, which spot in Koha are you talking about? (In reply to Owen Leonard from comment #1) > Where? Yeah, where? I have asked the librarian who reported the issue to be clearer on location. Sorry about that. Nicole I'm going to take a guess and say on the results page, when you list out all available copies. Created attachment 44873 [details]
Possible location
Not sure why you couldn't apply a different style to span class='unavailable' there though. I suspect this was an omission during the prog -> bootstrap conversion. Created attachment 48201 [details] [review] Bug 15071 - In OPAC search results, "checked out" status should be more visible The prog template in the OPAC designated a color for the "unavailable" class associated with items in search results which are checked out. This class never made it into the Bootstrap theme. This patch adds it to the Bootstrap theme's LESS file. To test, apply the patch and search the OPAC for terms that will return checked out items. In the list of search results, on the "availability" line, the "Checked out" text should now be red. The change is visible with XSLT on or off. Created attachment 48202 [details] [review] Bug 15071 - In OPAC search results, "checked out" status should be more visible Compiled CSS file. Created attachment 48236 [details] [review] [SIGNED-OFF] Bug 15071 - In OPAC search results, "checked out" status should be more visible The prog template in the OPAC designated a color for the "unavailable" class associated with items in search results which are checked out. This class never made it into the Bootstrap theme. This patch adds it to the Bootstrap theme's LESS file. To test, apply the patch and search the OPAC for terms that will return checked out items. In the list of search results, on the "availability" line, the "Checked out" text should now be red. The change is visible with XSLT on or off. Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> Created attachment 48237 [details] [review] [SIGNED-OFF] Bug 15071 - In OPAC search results, "checked out" status should be more visible Compiled CSS file. Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> Created attachment 48277 [details] [review] Bug 15071 - In OPAC search results, "checked out" status should be more visible The prog template in the OPAC designated a color for the "unavailable" class associated with items in search results which are checked out. This class never made it into the Bootstrap theme. This patch adds it to the Bootstrap theme's LESS file. To test, apply the patch and search the OPAC for terms that will return checked out items. In the list of search results, on the "availability" line, the "Checked out" text should now be red. The change is visible with XSLT on or off. Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 48278 [details] [review] Bug 15071 - In OPAC search results, "checked out" status should be more visible Compiled CSS file. Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 48354 [details] [review] Bug 15071 - In OPAC search results, "checked out" status should be more visible The prog template in the OPAC designated a color for the "unavailable" class associated with items in search results which are checked out. This class never made it into the Bootstrap theme. This patch adds it to the Bootstrap theme's LESS file. To test, apply the patch and search the OPAC for terms that will return checked out items. In the list of search results, on the "availability" line, the "Checked out" text should now be red. The change is visible with XSLT on or off. Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 48355 [details] [review] Bug 15071 - In OPAC search results, "checked out" status should be more visible Compiled CSS file. Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 48356 [details] [review] Bug 15071 [QA Followup] - Update compiled css again Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 48357 [details] [review] Bug 15071 - In OPAC search results, "checked out" status should be more visible The prog template in the OPAC designated a color for the "unavailable" class associated with items in search results which are checked out. This class never made it into the Bootstrap theme. This patch adds it to the Bootstrap theme's LESS file. To test, apply the patch and search the OPAC for terms that will return checked out items. In the list of search results, on the "availability" line, the "Checked out" text should now be red. The change is visible with XSLT on or off. Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 48358 [details] [review] Bug 15071 - In OPAC search results, "checked out" status should be more visible Compiled CSS file. Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 48359 [details] [review] Bug 15071 [QA Followup] - Update compiled css again Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 48360 [details] [review] Bug 15071 - In OPAC search results, "checked out" status should be more visible The prog template in the OPAC designated a color for the "unavailable" class associated with items in search results which are checked out. This class never made it into the Bootstrap theme. This patch adds it to the Bootstrap theme's LESS file. To test, apply the patch and search the OPAC for terms that will return checked out items. In the list of search results, on the "availability" line, the "Checked out" text should now be red. The change is visible with XSLT on or off. Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 48361 [details] [review] Bug 15071 - In OPAC search results, "checked out" status should be more visible - Compiled CSS Compiled CSS file. Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 48362 [details] [review] Bug 15071 [QA Followup] - Update compiled css again Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master, should be in the Koha 3.24 release! Thanks Owen! Patch pushed to 3.22.x, will be in 3.22.4 |