Bug 15080

Summary: ./translate-tool should tell if xgettext-executable is missing
Product: Koha Reporter: Olli-Antti Kivilahti <olli-antti.kivilahti>
Component: translate.koha-community.orgAssignee: Olli-Antti Kivilahti <olli-antti.kivilahti>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: f.demians, julian.maurice, jweaver
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 15080 - ./translate-tool should tell if xgettext-executable is missing
Bug 15080 - ./translate tool should tell if xgettext executable is missing
Bug 15080 - ./translate tool should tell if xgettext executable is missing

Description Olli-Antti Kivilahti 2015-10-29 13:40:40 UTC
Just upgraded our Koha container to 14.04 and noticing the misc/translator/translate doesn't work.
This is because of a missing package gettext.

This patch makes ./translate die with a helpful suggestion to install gettext if xgettext-program is missing.
Comment 1 Olli-Antti Kivilahti 2015-10-29 13:41:34 UTC Comment hidden (obsolete)
Comment 2 Frédéric Demians 2015-11-02 20:46:58 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2015-11-20 16:00:45 UTC
Created attachment 45057 [details] [review]
Bug 15080 - ./translate tool should tell if xgettext executable is missing

Just upgraded our Koha container to 14.04 and noticing the
misc/translator/translate doesn't work.  This is because of a missing
package gettext.

This patch makes ./translate die with a helpful suggestion to install
gettext if xgettext-program is missing.

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
  I can reproduce the bug by desinstalling 'gettext' package on a Debian
  box. I confirm that without this patch, 'translate' command fails
  miserably. Suggesting to install gettext package is welcomed.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Jesse Weaver 2015-12-30 23:30:41 UTC
Pushed to master. Thanks for your contribution!
Comment 5 Julian Maurice 2015-12-31 13:26:32 UTC
Patch pushed to 3.22.x, will be in 3.22.2
Comment 6 Frédéric Demians 2015-12-31 18:34:09 UTC
This patch has been pushed to 3.20.x, will be in 3.20.8.