| Summary: | Creators layout and template sql has warnings | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Mark Tompsett <mtompset> |
| Component: | Architecture, internals, and plumbing | Assignee: | Mark Tompsett <mtompset> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | chris, julian.maurice, kyle |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 15053 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 15086: Creators layout and template sql has warnings
Bug 15086: Creators layout and template sql has warnings [SIGNED-OFF] Bug 15086: Creators layout and template sql has warnings Bug 15086: Creators layout and template sql has warnings |
||
Created attachment 44180 [details] [review] Bug 15086: Creators layout and template sql has warnings When doing a hacked install off the master branch: use ... {koha database name} truncate creator_layouts; truncate creator_templates; truncate printers_profiles; source installer/data/mysql/... {name of a sample_labels type file} Warnings are generated, which may not be visible in the UI. Most of the warnings were triggered by: -/*!40000 ALTER TABLE `creator_layouts` DISABLE KEYS */; -/*!40000 ALTER TABLE `creator_layouts` ENABLE KEYS */; http://dev.mysql.com/doc/refman/5.7/en/error-messages-server.html#error_er_illegal_ha In the Russian, the layout_name was truncated, because the layout_name was only 20. An atomic update sql and kohastructure.sql update were provided to widen it to 25. http://dev.mysql.com/doc/refman/5.7/en/error-messages-server.html#error_warn_data_truncated Also fr-FR, ru-RU, and uk-UA were slightly different in structure, so the structure was made the same as the other files. See comment #1 for the test plan. NOTE: pl-PL is likely very out of date, but is not affected in this regard. Don't forget to apply 15053 first, before applying this. :) CONFLICT (content): Merge conflict in installer/data/mysql/it-IT/necessari/sample_creator_data.sql Created attachment 46233 [details] [review] Bug 15086: Creators layout and template sql has warnings When doing a hacked install off the master branch: use ... {koha database name} truncate creator_layouts; truncate creator_templates; truncate printers_profiles; source installer/data/mysql/... {name of a sample_labels type file} Warnings are generated, which may not be visible in the UI. Most of the warnings were triggered by: -/*!40000 ALTER TABLE `creator_layouts` DISABLE KEYS */; -/*!40000 ALTER TABLE `creator_layouts` ENABLE KEYS */; http://dev.mysql.com/doc/refman/5.7/en/error-messages-server.html#error_er_illegal_ha In the Russian, the layout_name was truncated, because the layout_name was only 20. An atomic update sql and kohastructure.sql update were provided to widen it to 25. http://dev.mysql.com/doc/refman/5.7/en/error-messages-server.html#error_warn_data_truncated Also fr-FR, ru-RU, and uk-UA were slightly different in structure, so the structure was made the same as the other files. See comment #1 for the test plan. NOTE: pl-PL is likely very out of date, but is not affected in this regard. it-IT was updated in Bug 15178 which added a line feed causing conflict. Created attachment 51444 [details] [review] [SIGNED-OFF] Bug 15086: Creators layout and template sql has warnings When doing a hacked install off the master branch: use ... {koha database name} truncate creator_layouts; truncate creator_templates; truncate printers_profiles; source installer/data/mysql/... {name of a sample_labels type file} Warnings are generated, which may not be visible in the UI. Most of the warnings were triggered by: -/*!40000 ALTER TABLE `creator_layouts` DISABLE KEYS */; -/*!40000 ALTER TABLE `creator_layouts` ENABLE KEYS */; http://dev.mysql.com/doc/refman/5.7/en/error-messages-server.html#error_er_illegal_ha In the Russian, the layout_name was truncated, because the layout_name was only 20. An atomic update sql and kohastructure.sql update were provided to widen it to 25. http://dev.mysql.com/doc/refman/5.7/en/error-messages-server.html#error_warn_data_truncated Also fr-FR, ru-RU, and uk-UA were slightly different in structure, so the structure was made the same as the other files. See comment #1 for the test plan. NOTE: pl-PL is likely very out of date, but is not affected in this regard. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works, no more warnings mysql> show warnings; Empty set (0.01 sec) No errors Created attachment 51486 [details] [review] Bug 15086: Creators layout and template sql has warnings When doing a hacked install off the master branch: use ... {koha database name} truncate creator_layouts; truncate creator_templates; truncate printers_profiles; source installer/data/mysql/... {name of a sample_labels type file} Warnings are generated, which may not be visible in the UI. Most of the warnings were triggered by: -/*!40000 ALTER TABLE `creator_layouts` DISABLE KEYS */; -/*!40000 ALTER TABLE `creator_layouts` ENABLE KEYS */; http://dev.mysql.com/doc/refman/5.7/en/error-messages-server.html#error_er_illegal_ha In the Russian, the layout_name was truncated, because the layout_name was only 20. An atomic update sql and kohastructure.sql update were provided to widen it to 25. http://dev.mysql.com/doc/refman/5.7/en/error-messages-server.html#error_warn_data_truncated Also fr-FR, ru-RU, and uk-UA were slightly different in structure, so the structure was made the same as the other files. See comment #1 for the test plan. NOTE: pl-PL is likely very out of date, but is not affected in this regard. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works, no more warnings mysql> show warnings; Empty set (0.01 sec) No errors Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for Koha 16.05, thanks Mark! Patch pushed to 3.22.x, will be in 3.22.7 |
When doing a hacked install: use ... {koha database name} truncate creator_layouts; truncate creator_templates; truncate printers_profiles; source installer/data/mysql/... {name of a sample_labels type file} Warnings are generated, which may not be visible in the UI. TEST PLAN --------- (1) Run this BEFORE applying: truncate creator_layouts; truncate creator_templates; truncate printers_profile; source installer/data/mysql/de-DE/optional/sample_creator_data.sql truncate creator_layouts; truncate creator_templates; truncate printers_profile; source installer/data/mysql/es-ES/optional/sample_creator_data.sql truncate creator_layouts; truncate creator_templates; truncate printers_profile; source installer/data/mysql/fr-FR/2-Optionel/sample_labels.sql truncate creator_layouts; truncate creator_templates; truncate printers_profile; source installer/data/mysql/it-IT/necessari/sample_creator_data.sql truncate creator_layouts; truncate creator_templates; truncate printers_profile; source installer/data/mysql/nb-NO/2-Valgfritt/sample_creator_data.sql truncate creator_layouts; truncate creator_templates; truncate printers_profile; source installer/data/mysql/ru-RU/optional/print_labels.sql truncate creator_layouts; truncate creator_templates; truncate printers_profile; source installer/data/mysql/uk-UA/optional/print_labels.sql truncate creator_layouts; truncate creator_templates; truncate printers_profile; source installer/data/mysql/en/optional/sample_creator_data.sql --Notice the warnings show warnings; -- Most of them are the: -/*!40000 ALTER TABLE `creator_layouts` DISABLE KEYS */; -/*!40000 ALTER TABLE `creator_layouts` ENABLE KEYS */; In the Russian, the layout_name was truncated, because the layout_name was only 20. An atomic update sql and kohastructure.sql update were provided to widen it to 25. (2) Apply the patch (3) Run the database update (4) Redo step (1) -- There should be no warnings or errors NOTE: fr-FR, ru-RU, and uk-UA were slightly different in structure, so the structure was made the same as the other files.