Summary: | Fix date filter for Suggestions management | ||
---|---|---|---|
Product: | Koha | Reporter: | Marc Véron <veron> |
Component: | Acquisitions | Assignee: | Marc Véron <veron> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P1 - high | CC: | jonathan.druart, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 15090: Fix date filter for Suggestions management
Bug 15090: Fix date filter for Suggestions management [PASSED QA] Bug 15090: Fix date filter for Suggestions management |
Description
Marc Véron
2015-10-30 14:21:05 UTC
Ccing Jonathan Created attachment 44201 [details] [review] Bug 15090: Fix date filter for Suggestions management Home > Acquisitions > Suggestions management: Before 13813 the "from" date in filters was 0000-00-00 if not filled, afer 13813 it's today. This patch re-introduces 0000-00-00. See http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813#c172 To test: - Go to Home > Acquisitions > Suggestions management - Verify that date filters work as expected - Verify that start dates in sql query are 0000-00-00 if no start dates are given - Note: Line 185 outputs the start dates as warn if $debug is set. Created attachment 44258 [details] [review] Bug 15090: Fix date filter for Suggestions management Home > Acquisitions > Suggestions management: Before 13813 the "from" date in filters was 0000-00-00 if not filled, afer 13813 it's today. This patch re-introduces 0000-00-00. See http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813#c172 To test: - Go to Home > Acquisitions > Suggestions management - Verify that date filters work as expected - Verify that start dates in sql query are 0000-00-00 if no start dates are given - Note: Line 185 outputs the start dates as warn if $debug is set. Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> Created attachment 44279 [details] [review] [PASSED QA] Bug 15090: Fix date filter for Suggestions management Home > Acquisitions > Suggestions management: Before 13813 the "from" date in filters was 0000-00-00 if not filled, afer 13813 it's today. This patch re-introduces 0000-00-00. See http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813#c172 To test: - Go to Home > Acquisitions > Suggestions management - Verify that date filters work as expected - Verify that start dates in sql query are 0000-00-00 if no start dates are given - Note: Line 185 outputs the start dates as warn if $debug is set. Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patch pushed to master. Thanks Marc! |