Description
Katrin Fischer
2015-11-01 20:35:57 UTC
Created attachment 44616 [details] [review] Bug 15102 - Fix capitalization for some strings on XSLT detail pages To test: -Apply on top bug 15100 -Search records with 336, 337, 338, 700$i, and 7XXind=2 -Notice the capitalization (Contained Works, Related Works, Media Type, Content Type, and Carrier Type) in both OPAC and Intranet for records detail pages -Apply this patch -Search again and get notice about the capitalization following Koha coding guidelines. Created attachment 44619 [details] [review] Bug 15102-(follow-up)Fix capitalization of multiples fields on XSLT Intranet/OPAC To test: -Search records with 508, 264Ind=4, 246, 856, and 008LDR/6 and LDR/7 (BK, VM, CR, CF) -Notice the capitalization (Production Credits, Copyright Date, Other Title, Online Access, Continuing Resource, Mixed Materials, Computer File, Visual Material) in both OPAC and Intranet for records detail pages and results pages -Apply this patch -Reindex zebra if you stage some new records (avoid if not) -Search again and get notice about the capitalization following Koha coding guidelines. Created attachment 44620 [details] [review] Bug 15102-(follow-up)Fix capitalization of multiples fields on XSLT Intranet/OPAC To test: -Search records with 508, 264Ind=4, 246, 856, and 008LDR/6 and LDR/7 (BK, VM, CR, CF) -Notice the capitalization (Production Credits, Copyright Date, Other Title, Online Access, Continuing Resource, Mixed Materials, Computer File, Visual Material) in both OPAC and Intranet for records detail pages and results pages -Apply this patch -Reindex zebra if you stage some new records (avoid if not) -Search again and get notice about the capitalization following Koha coding guidelines. Holdings or Item information is still in capitalization (Visual Materials, Non Fiction, Continuing Resources) but this need changes in SQL statements. I think IMHO this need to file another bug. Could you submit a single patch rather than two? This would help the proof reading. Created attachment 44673 [details] [review] Bug 15102 - Fix capitalization for some strings on XSLT detail pages To test: -Search records with 336, 337, 338, 700$i, and 7XXind=2 -Search records with 508, 264Ind=4, 246, 856, and LDR/6 and LDR/7 (BK, VM, CR, CF) -Notice the capitalization (Contained Works, Related Works, Media Type, Content Type, and Carrier Type, Production Credits, Copyright Date, Other Title, Online Access, Continuing Resource, Mixed Materials, Computer File, Visual Material) in both OPAC and Intranet for records detail pages and results pages -Apply this patch -Search again and get notice about the capitalization following Koha coding guidelines HI Frédéric The two commits squashed Created attachment 44678 [details] [review] Bug 15102 - Fix capitalization for some strings on XSLT detail pages To test: -Search records with 336, 337, 338, 700$i, and 7XXind=2 -Search records with 508, 264Ind=4, 246, 856, and LDR/6 and LDR/7 (BK, VM, CR, CF) -Notice the capitalization (Contained Works, Related Works, Media Type, Content Type, and Carrier Type, Production Credits, Copyright Date, Other Title, Online Access, Continuing Resource, Mixed Materials, Computer File, Visual Material) in both OPAC and Intranet for records detail pages and results pages -Apply this patch -Search again and get notice about the capitalization following Koha coding guidelines Signed-off-by: Frederic Demians <f.demians@tamil.fr> Created attachment 44680 [details] [review] Bug 15102 - Fix capitalization for some strings on XSLT detail pages To test: -Search records with 336, 337, 338, 700$i, and 7XXind=2 -Search records with 508, 264Ind=4, 246, 856, and LDR/6 and LDR/7 (BK, VM, CR, CF) -Notice the capitalization (Contained Works, Related Works, Media Type, Content Type, and Carrier Type, Production Credits, Copyright Date, Other Title, Online Access, Continuing Resource, Mixed Materials, Computer File, Visual Material) in both OPAC and Intranet for records detail pages and results pages -Apply this patch -Search again and get notice about the capitalization following Koha coding guidelines Signed-off-by: Frederic Demians <f.demians@tamil.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Patch pushed to master. Thanks Hector! |