|
Description
Kyle M Hall (khall)
2015-11-02 16:46:18 UTC
Created attachment 44288 [details] [review] Bug 15109 - Regression in patron search results ordering In Koha 3.16 or earlier, before the introduction of the ajax datatable for patron searching, the search results were ordered by name. In master, the results are currently ordered by cardnumber, which is not very useful. Test Plan: 1) Do a "browse by last name" or a patron search 2) Note the results are sorted by card number 3) Apply this patch 4) Reload the page, start a new search 5) Note the results are sorted by name Created attachment 44296 [details] [review] Bug 15109 - Regression in patron search results ordering In Koha 3.16 or earlier, before the introduction of the ajax datatable for patron searching, the search results were ordered by name. In master, the results are currently ordered by cardnumber, which is not very useful. Test Plan: 1) Do a "browse by last name" or a patron search 2) Note the results are sorted by card number 3) Apply this patch 4) Reload the page, start a new search 5) Note the results are sorted by name Followed test plan. Worked as expecting (after a browser reload). Signed-off-by: Marc Véron <veron@veron.ch> Marc you forgot to change bug status. There is already a DT sort parameter in the template: 'aaSorting': [[1, 'asc']], This one should be modified. Moreover this script does not check for the existence of the checkboxes in the first column ([% IF CAN_user_tools_manage_patron_lists %]), which places the cardnumber in 0 or 1. I will provide a counter patch. Created attachment 44829 [details] [review] Bug 15109 - Regression in patron search results ordering In Koha 3.16 or earlier, before the introduction of the ajax datatable for patron searching, the search results were ordered by name. In master, the results are currently ordered by cardnumber, which is not very useful. Test Plan: 1) Do a "browse by last name" or a patron search 2) Note the results are sorted by card number 3) Apply this patch 4) Reload the page, start a new search 5) Note the results are sorted by name Created attachment 44830 [details] [review] Bug 15109: Make name the default sort order for all patron searches Find another place where there is a patron search (add user to a basket, add users to a fund or edit owner of a fund, set a guarantor to a child, etc.). Do a search a confirm that the results are now sorted by name instead of cardnumber. Created attachment 44854 [details] [review] Bug 15109 - Regression in patron search results ordering In Koha 3.16 or earlier, before the introduction of the ajax datatable for patron searching, the search results were ordered by name. In master, the results are currently ordered by cardnumber, which is not very useful. Test Plan: 1) Do a "browse by last name" or a patron search 2) Note the results are sorted by card number 3) Apply this patch 4) Reload the page, start a new search 5) Note the results are sorted by name Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> Created attachment 44855 [details] [review] Bug 15109: Make name the default sort order for all patron searches Find another place where there is a patron search (add user to a basket, add users to a fund or edit owner of a fund, set a guarantor to a child, etc.). Do a search a confirm that the results are now sorted by name instead of cardnumber. Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> Created attachment 44892 [details] [review] [PASSED QA] Bug 15109 - Regression in patron search results ordering In Koha 3.16 or earlier, before the introduction of the ajax datatable for patron searching, the search results were ordered by name. In master, the results are currently ordered by cardnumber, which is not very useful. Test Plan: 1) Do a "browse by last name" or a patron search 2) Note the results are sorted by card number 3) Apply this patch 4) Reload the page, start a new search 5) Note the results are sorted by name Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 44893 [details] [review] [PASSED QA] Bug 15109: Make name the default sort order for all patron searches Find another place where there is a patron search (add user to a basket, add users to a fund or edit owner of a fund, set a guarantor to a child, etc.). Do a search a confirm that the results are now sorted by name instead of cardnumber. Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patches pushed to master. Thanks Jonathan! This patch has been pushed to 3.20.x, will be in 3.20.6. Pushed to 3.18.13, and released. |