| Summary: | koha-rebuild-zebra should check USE_INDEXER_DAEMON and skip if enabled | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Component: | Command-line Utilities | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | brendan, f.demians, hector.hecaxmmx, julian.maurice, mtj, robin |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 16190 | ||
| Attachments: |
Bug 15113: koha-rebuild-zebra should check USE_INDEXER_DAEMON and skip if enabled
[SIGNED-OFF]Bug 15113: koha-rebuild-zebra should check USE_INDEXER_DAEMON and skip if enabled Bug 15113: koha-rebuild-zebra should check USE_INDEXER_DAEMON and skip if enabled |
||
|
Description
Tomás Cohen Arazi (tcohen)
2015-11-03 01:49:48 UTC
Created attachment 49811 [details] [review] Bug 15113: koha-rebuild-zebra should check USE_INDEXER_DAEMON and skip if enabled This patch changes the behaviour of the koha-rebuild-zebra script in the following way: USE_INDEXER_DAEMON=no - Keeps the current behaviour USE_INDEXER_DAEMON=yes - It skips incremental indexing to avoid races. Caveats: - A --force option is introduced for useing in a specific situtation that might need it (i.e. the administrator knows what he's doing). - If --full is passed, the reindexing is not skipped. The documentation files and messages are adjusted accordingly. This patch should help users that want to use the indexing daemon, in which case they wouldn't need to change their default 5 min cronjob (it will be just skipped). Ultimately, koha-common could have USE_INDEXER_DAEMON = yes by default, but that's subject for another bug report. To test: - Play with the different option switches and USE_INDEXER_DAEMON - Things work as expected - Sign off Regards Created attachment 50004 [details] [review] [SIGNED-OFF]Bug 15113: koha-rebuild-zebra should check USE_INDEXER_DAEMON and skip if enabled This patch changes the behaviour of the koha-rebuild-zebra script in the following way: USE_INDEXER_DAEMON=no - Keeps the current behaviour USE_INDEXER_DAEMON=yes - It skips incremental indexing to avoid races. Caveats: - A --force option is introduced for useing in a specific situtation that might need it (i.e. the administrator knows what he's doing). - If --full is passed, the reindexing is not skipped. The documentation files and messages are adjusted accordingly. This patch should help users that want to use the indexing daemon, in which case they wouldn't need to change their default 5 min cronjob (it will be just skipped). Ultimately, koha-common could have USE_INDEXER_DAEMON = yes by default, but that's subject for another bug report. To test: - Play with the different option switches and USE_INDEXER_DAEMON - Things work as expected - Sign off Regards Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as expected Created attachment 50019 [details] [review] Bug 15113: koha-rebuild-zebra should check USE_INDEXER_DAEMON and skip if enabled This patch changes the behaviour of the koha-rebuild-zebra script in the following way: USE_INDEXER_DAEMON=no - Keeps the current behaviour USE_INDEXER_DAEMON=yes - It skips incremental indexing to avoid races. Caveats: - A --force option is introduced for useing in a specific situtation that might need it (i.e. the administrator knows what he's doing). - If --full is passed, the reindexing is not skipped. The documentation files and messages are adjusted accordingly. This patch should help users that want to use the indexing daemon, in which case they wouldn't need to change their default 5 min cronjob (it will be just skipped). Ultimately, koha-common could have USE_INDEXER_DAEMON = yes by default, but that's subject for another bug report. To test: - Play with the different option switches and USE_INDEXER_DAEMON - Things work as expected - Sign off Regards Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as expected Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - Should be in the May 2016 Release. Thanks! Patch pushed to 3.22.x, will be in 3.22.6 Pushed to 3.22.x, will be in 3.20.11. |