Summary: | warning on purchase suggestions is inaccurate | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Templates | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | f.demians, jonathan.druart, liz, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
error
Bug 15114: Fix typo in opac-suggestion template Bug 15114: Fix typo in opac-suggestion template [PASSED QA] Bug 15114: Fix typo in opac-suggestion template |
Created attachment 44848 [details] [review] Bug 15114: Fix typo in opac-suggestion template There is a $ in front of the loggedinusername variable, which is obviously not what is expected here. It fixes the wrong warning message "You are not authorized to see pending purchase suggestions." when it should be "There are no pending purchase suggestions." Created attachment 44883 [details] [review] Bug 15114: Fix typo in opac-suggestion template There is a $ in front of the loggedinusername variable, which is obviously not what is expected here. It fixes the wrong warning message "You are not authorized to see pending purchase suggestions." when it should be "There are no pending purchase suggestions." Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Created attachment 44890 [details] [review] [PASSED QA] Bug 15114: Fix typo in opac-suggestion template There is a $ in front of the loggedinusername variable, which is obviously not what is expected here. It fixes the wrong warning message "You are not authorized to see pending purchase suggestions." when it should be "There are no pending purchase suggestions." Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patch pushed to master. Thanks Jonathan! This patch has been pushed to 3.20.x, will be in 3.20.6. Pushed to 3.18.13, and released. |
Created attachment 44333 [details] error When on the purchase suggestions page in the OPAC if there are no suggestions you get a warning "You are not authorized to see pending purchase suggestions." But once you add a suggestion that goes away.