| Summary: | There is no translation of confirm dialog when transfering a basket | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Genevieve Plantin <genevieve.plantin> |
| Component: | I18N/L10N | Assignee: | Marc Véron <veron> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | eric.begin, f.demians, francois.charbonnier, genevieve.plantin, jonathan.druart, liz, philippe.blouin, tomascohen, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 15117: Transfer Order: Better user information and translation handling
Bug 15117: Transfer Order: Better user information and translation handling Bug 15117: Transfer Order: Better user information and translation handling |
||
|
Description
Genevieve Plantin
2015-11-03 21:21:16 UTC
Created attachment 44354 [details] [review] Bug 15117: Transfer Order: Better user information and translation handling While transferring an order, a untranslatable JavaScript confirmation dialog pops up. This patch moves the information about the order to be transferred to the top of the screen to better inform the user what order is to be transferred, and simplifies the confirmation dialog. To test: - Apply patch - Transfer an order from a basket to another basket - Verify, that on top of the screen an information is displayed about which order from which vendor and basket is to be transferred - Verify that the transfer works OK - Update a po lang file and confirm you see the string and you are able to translate it. Created attachment 44535 [details] [review] Bug 15117: Transfer Order: Better user information and translation handling While transferring an order, a untranslatable JavaScript confirmation dialog pops up. This patch moves the information about the order to be transferred to the top of the screen to better inform the user what order is to be transferred, and simplifies the confirmation dialog. To test: - Apply patch - Transfer an order from a basket to another basket - Verify, that on top of the screen an information is displayed about which order from which vendor and basket is to be transferred - Verify that the transfer works OK - Update a po lang file and confirm you see the string and you are able to translate it. Signed-off-by: Frederic Demians <f.demians@tamil.fr> Dialog box with readable & translatable info. Created attachment 44547 [details] [review] Bug 15117: Transfer Order: Better user information and translation handling While transferring an order, a untranslatable JavaScript confirmation dialog pops up. This patch moves the information about the order to be transferred to the top of the screen to better inform the user what order is to be transferred, and simplifies the confirmation dialog. To test: - Apply patch - Transfer an order from a basket to another basket - Verify, that on top of the screen an information is displayed about which order from which vendor and basket is to be transferred - Verify that the transfer works OK - Update a po lang file and confirm you see the string and you are able to translate it. Signed-off-by: Frederic Demians <f.demians@tamil.fr> Dialog box with readable & translatable info. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Marc, why did not you keep the original wording? (In reply to Jonathan Druart from comment #4) > Marc, why did not you keep the original wording? For the JS confirmation? - Because the information about "from where / where to" now is displayed on the screen. But I'm not against it if you restore it in a follow up. I am sure we could improve it, even if the info are on the page "Transfer order to this basket" sounds a bit rude :) Patch pushed to master. Thanks Marc! This patch has been pushed to 3.20.x, will be in 3.20.6. Pushed to 3.18.13, and released. |