Summary: | Give SCO separate control for AllowItemsOnHoldCheckout | ||
---|---|---|---|
Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
Component: | Self checkout | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | amy, gwilliams, jonathan.druart, nicole, sandboxes, tomascohen |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 15131: Instroduce AllowItemsOnHoldCheckoutSCO syspref
Bug 15131: Make SCO use the new syspref. Bug 15131: Instroduce AllowItemsOnHoldCheckoutSCO syspref Bug 15131: Make SCO use the new syspref. Bug 15131: Instroduce AllowItemsOnHoldCheckoutSCO syspref Bug 15131: Make SCO use the new syspref. Bug 15131: Add AllowItemsOnHoldCheckoutSCO to UsageStats |
Description
Kyle M Hall (khall)
2015-11-04 16:14:28 UTC
Created attachment 53273 [details] [review] Bug 15131: Instroduce AllowItemsOnHoldCheckoutSCO syspref This patch introduces a new syspref AllowItemsOnHoldCheckoutSCO, so the current AllowItemsOnHoldCheckout syspref can be decoupled for the SCO module, giving the library more flexibility. During upgrade, it gets its value from the original AllowItemsOnHoldCheckout syspref. Sponsored-by: NEKLS Created attachment 53274 [details] [review] Bug 15131: Make SCO use the new syspref. This patch just makes SCO use the new syspref (AllowItemsOnHoldCheckoutSCO) instead of the old one, thus making it configurable, separate from the non-SCO syspref. Sponsored-by: NEKLS I'd like to test this, but could you add a test plan? George Sorry, I forgot to add the steps to test this patchset! To test, you need to: - Apply the patches on master - Run: $ sudo koha-upgrade-schema kohadev => SUCCESS: Verify that AllowItemsOnHoldCheckoutSCO is set to the same value AllowItemsOnHoldCheckout was set - Have an item that fills a hold - Set AllowItemsOnHoldCheckoutSCO to "Don't allow" - Try doing a checkout on the item, from the SCO interface => SUCCESS: You cannot. - Set AllowItemsOnHoldCheckout to "Allow" - Try doing a checkout on the item, from the SCO interface => SUCCESS: You cannot. The sysprefs are decoupled now. - Set AllowItemsOnHoldCheckoutSCO to "Allow" - Try doing a checkout on the item, from the SCO interface => SUCCESS: You can. - Sign off :-D Patch tested with a sandbox, by George <george@nekls.org> Created attachment 55696 [details] [review] Bug 15131: Instroduce AllowItemsOnHoldCheckoutSCO syspref This patch introduces a new syspref AllowItemsOnHoldCheckoutSCO, so the current AllowItemsOnHoldCheckout syspref can be decoupled for the SCO module, giving the library more flexibility. During upgrade, it gets its value from the original AllowItemsOnHoldCheckout syspref. Sponsored-by: NEKLS Signed-off-by: George <george@nekls.org> Created attachment 55697 [details] [review] Bug 15131: Make SCO use the new syspref. This patch just makes SCO use the new syspref (AllowItemsOnHoldCheckoutSCO) instead of the old one, thus making it configurable, separate from the non-SCO syspref. Sponsored-by: NEKLS Signed-off-by: George <george@nekls.org> Created attachment 55883 [details] [review] Bug 15131: Instroduce AllowItemsOnHoldCheckoutSCO syspref This patch introduces a new syspref AllowItemsOnHoldCheckoutSCO, so the current AllowItemsOnHoldCheckout syspref can be decoupled for the SCO module, giving the library more flexibility. During upgrade, it gets its value from the original AllowItemsOnHoldCheckout syspref. Sponsored-by: NEKLS Signed-off-by: George <george@nekls.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 55884 [details] [review] Bug 15131: Make SCO use the new syspref. This patch just makes SCO use the new syspref (AllowItemsOnHoldCheckoutSCO) instead of the old one, thus making it configurable, separate from the non-SCO syspref. Sponsored-by: NEKLS Signed-off-by: George <george@nekls.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 55885 [details] [review] Bug 15131: Add AllowItemsOnHoldCheckoutSCO to UsageStats Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Note: There was something wrong in our doc: """ Important This system preference relates only to SIP based self checkout, not Koha's web based self checkout. """ That was wrong but will be true after this patch. Pushed to master for 16.11, thanks Tomas, Jonathan! |