A side note from a non-UNIMARC guy: when I wrote the facets section for biblio-koha-indexdefs.xml (UNIMARC) I just grabbed the facet creation information from C4::Koha->getFacets(). So the Zebra facets are defined exactly as to old ones. There is an index "Title-uniform" should it be used for 500 and facet su-ut ? The Titles facet still doesn't work for UNIMARC installations (I've tested versions 16.05.16 and 17.05.05). We fixed this by changing the zebra index name to 'Subject,Subject:p'. In the end I think the best solution is to remove this facet for UNIMARC Created attachment 95726 [details] [review] Bug 15142: Remove titles facet for UNIMARC There is a facet using 500$a, 501$a and 503$a and Subject index. In UNIMARC 500$a, 501$a and 503$a are not indexed as Subject. I propose to remove this facet for UNIMARC, looks like it does not make sens. Test plan: 1) Install UNIMARC database 2) Edit some records to have 500$a 3) Perform a search to find those records 4) Check you dont see the titles facet Created attachment 95753 [details] [review] Bug 15142: Remove titles facet for UNIMARC There is a facet using 500$a, 501$a and 503$a and Subject index. In UNIMARC 500$a, 501$a and 503$a are not indexed as Subject. I propose to remove this facet for UNIMARC, looks like it does not make sens. Test plan: 1) Install UNIMARC database 2) Edit some records to have 500$a 3) Perform a search to find those records 4) Check you dont see the titles facet Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Should not it be removed from xsl and xml files in etc/zebradb/marc_defs/unimarc/biblios? Created attachment 95810 [details] [review] Bug 15142: (follow-up) remove from Zebra UNIMARC config files (In reply to Jonathan Druart from comment #7) > Should not it be removed from xsl and xml files in > etc/zebradb/marc_defs/unimarc/biblios? Yes indeed Created attachment 96696 [details] [review] Bug 15142: Remove titles facet for UNIMARC There is a facet using 500$a, 501$a and 503$a and Subject index. In UNIMARC 500$a, 501$a and 503$a are not indexed as Subject. I propose to remove this facet for UNIMARC, looks like it does not make sens. Test plan: 1) Install UNIMARC database 2) Edit some records to have 500$a 3) Perform a search to find those records 4) Check you dont see the titles facet Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 96697 [details] [review] Bug 15142: (follow-up) remove from Zebra UNIMARC config files Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 96698 [details] [review] Bug 15142: (follow-up) Remove facet configuration from .xsl file Removes last remaining bit of configuration for the Titles facet configuration. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 97193 [details] [review] Bug 15142: Remove titles facet for UNIMARC There is a facet using 500$a, 501$a and 503$a and Subject index. In UNIMARC 500$a, 501$a and 503$a are not indexed as Subject. I propose to remove this facet for UNIMARC, looks like it does not make sens. Test plan: 1) Install UNIMARC database 2) Edit some records to have 500$a 3) Perform a search to find those records 4) Check you dont see the titles facet Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 97194 [details] [review] Bug 15142: (follow-up) remove from Zebra UNIMARC config files Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 97195 [details] [review] Bug 15142: (follow-up) Remove facet configuration from .xsl file Removes last remaining bit of configuration for the Titles facet configuration. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Nice work everyone! Pushed to master for 20.05 Pushed to 19.11.x branch for 19.11.03 backported to 19.05.x for 19.05.08 Enhancement will not be backported to 18.11.x series. |
There is a "Titles" facet using in UNIMARC 500$a, 501$a and 503$a : In etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml <facet tag="500" subfields="a"> <target_index>su-ut:0</target_index> </facet> <facet tag="501" subfields="a"> <target_index>su-ut:0</target_index> </facet> <facet tag="503" subfields="a"> <target_index>su-ut:0</target_index> </facet> In etc/zebradb/ccl.properties : su-ut Subject The problem is that 500$a, 501$a and 503$a are not indexed as Subject : In etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml <!--record.abs line 262: melm 500 Title,Title:p--> <index_data_field tag="500"> <target_index>Title:w</target_index> <target_index>Title:p</target_index> </index_data_field> <!--record.abs line 263: melm 501 Title,Title:p--> <index_data_field tag="501"> <target_index>Title:w</target_index> <target_index>Title:p</target_index> </index_data_field> <!--record.abs line 264: melm 503 Title,Title:p--> <index_data_field tag="503"> <target_index>Title:w</target_index> <target_index>Title:p</target_index> </index_data_field> How should we change this configuration ? In MARC21, this facet uses field 630 that is indexed as Subject.