Summary: | Allow correct translation for upload local cover image | ||
---|---|---|---|
Product: | Koha | Reporter: | Héctor Eduardo Castro Avalos <hector.hecaxmmx> |
Component: | I18N/L10N | Assignee: | Bugs List <koha-bugs> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | bgkriegel, f.demians, liz, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | String patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 15154 - Allow correct translation for upload local cover image
Bug 15154 - Allow correct translation for upload local cover image Bug 15154 - Allow correct translation for upload local cover image [PASSED QA] Bug 15154 - Allow correct translation for upload local cover image |
Description
Héctor Eduardo Castro Avalos
2015-11-06 19:44:11 UTC
Sorry my mistake, the string really works well for translation purpose. Still can use for a better context in translation The phrase "Please, %upload% one" isn't a good phrase for translation. It is much better something like "Select the image file to upload" Created attachment 44607 [details] [review] Bug 15154 - Allow correct translation for upload local cover image To test: -Set syspref LocalCoverImages and OPACLocalCoverImages to Allow -A new tab 'Images' appear in bib record detail on Intranet. -Notice about the phrase "Please upload one" -Apply the patch and reload the page. -New phrase appear "Select the image file to upload" with button Upload -Update translation files : cd misc/translator; perl translate update es-ES -You will see in es-ES-staff-prog.po the new entry "Select the image file to upload. %sUpload%s" -You can see the result installing the translation cd misc/translator ; perl translate install es-ES Created attachment 44608 [details] [review] Bug 15154 - Allow correct translation for upload local cover image To test: -Set syspref LocalCoverImages and OPACLocalCoverImages to Allow -A new tab 'Images' appear in bib record detail on Intranet. -Select a bib record without a local cover image -Notice about the phrase "Please upload one" -Apply the patch and reload the page. -New phrase appear "Select the image file to upload" with button Upload -Update translation files : cd misc/translator; perl translate update es-ES -You will see in es-ES-staff-prog.po the new entry "Select the image file to upload. %sUpload%s" -You can see the result installing the translation cd misc/translator ; perl translate install es-ES Created attachment 44609 [details] [review] Bug 15154 - Allow correct translation for upload local cover image To test: -Set syspref LocalCoverImages and OPACLocalCoverImages to Allow -A new tab 'Images' appear in bib record detail on Intranet. -Notice about the phrase "Please upload one" -Apply the patch and reload the page. -New phrase appear "Select the image file to upload" with button Upload -Update translation files : cd misc/translator; perl translate update es-ES -You will see in es-ES-staff-prog.po the new entry "Select the image file to upload. %sUpload%s" -You can see the result installing the translation cd misc/translator ; perl translate install es-ES Signed-off-by: Frederic Demians <f.demians@tamil.fr> A native English speaker could confirm that the wording is ok: Please select the image file to upload Created attachment 44784 [details] [review] [PASSED QA] Bug 15154 - Allow correct translation for upload local cover image To test: -Set syspref LocalCoverImages and OPACLocalCoverImages to Allow -A new tab 'Images' appear in bib record detail on Intranet. -Notice about the phrase "Please upload one" -Apply the patch and reload the page. -New phrase appear "Select the image file to upload" with button Upload -Update translation files : cd misc/translator; perl translate update es-ES -You will see in es-ES-staff-prog.po the new entry "Select the image file to upload. %sUpload%s" -You can see the result installing the translation cd misc/translator ; perl translate install es-ES Signed-off-by: Frederic Demians <f.demians@tamil.fr> A native English speaker could confirm that the wording is ok: Please select the image file to upload Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patch pushed to master. Thanks Hector! This patch has been pushed to 3.20.x, will be in 3.20.6. Pushed to 3.18.13, and released. |