| Summary: | Searching serials expiring after today should be allowed | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Serials | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | colin.campbell, f.demians, tomascohen, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 8436 | ||
| Bug Blocks: | 14969 | ||
| Attachments: |
Bug 15171: Display subscriptions which will expire in the future
Bug 15171: Display subscriptions which will expire in the future [PASSED QA] Bug 15171: Display subscriptions which will expire in the future |
||
|
Description
Jonathan Druart
2015-11-11 09:31:05 UTC
Created attachment 44730 [details] [review] Bug 15171: Display subscriptions which will expire in the future Since the form on the subscription check expiration page let the user choose an expiration date > today, there is no sense to hide subscriptions which will expire in the future. Test plan: 0/ Make sure you have at least subscription with an expiration date > today 1/ Start a seach on the check expiration page (serials/checkexpiration.pl) with a date < today, = today and > today => The subscription won't never be displayed without this patch. With this patch, it will. Note that you will get a "No results for your query" message only if you have search for something. Created attachment 44734 [details] [review] Bug 15171: Display subscriptions which will expire in the future Since the form on the subscription check expiration page let the user choose an expiration date > today, there is no sense to hide subscriptions which will expire in the future. Test plan: 0/ Make sure you have at least subscription with an expiration date > today 1/ Start a seach on the check expiration page (serials/checkexpiration.pl) with a date < today, = today and > today => The subscription won't never be displayed without this patch. With this patch, it will. Note that you will get a "No results for your query" message only if you have search for something. Followed testplan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 44783 [details] [review] [PASSED QA] Bug 15171: Display subscriptions which will expire in the future Since the form on the subscription check expiration page let the user choose an expiration date > today, there is no sense to hide subscriptions which will expire in the future. Test plan: 0/ Make sure you have at least subscription with an expiration date > today 1/ Start a seach on the check expiration page (serials/checkexpiration.pl) with a date < today, = today and > today => The subscription won't never be displayed without this patch. With this patch, it will. Note that you will get a "No results for your query" message only if you have search for something. Followed testplan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patch pushed to master. Thanks Jonathan! This patch has been pushed to 3.20.x, will be in 3.20.6. (In reply to Frédéric Demians from comment #5) > This patch has been pushed to 3.20.x, will be in 3.20.6. % git checkout v3.20.07 HEAD is now at 95a5b0d... Translation updates for Koha 3.20 release % perl -wc serials/checkexpiration.pl Global symbol "$branch" requires explicit package name (did you forget to declare "my $branch"?) at serials/checkexpiration.pl line 84. Global symbol "$branch" requires explicit package name (did you forget to declare "my $branch"?) at serials/checkexpiration.pl line 84. serials/checkexpiration.pl had compilation errors. Frédéric, this patch depends on the $branch var, added by bug 8436. I would revert this patch from 3.20.x Reported on the mailing list: https://lists.katipo.co.nz/pipermail/koha/2016-March/044907.html (In reply to Jonathan Druart from comment #8) > Reported on the mailing list: > https://lists.katipo.co.nz/pipermail/koha/2016-March/044907.html Thanks. Take a look immediately. Do you know why Jenkins don't run anymore tests for 3.20 branch. I've already reverted this patch December 29th. So the bug reported on mailing list is there in 3.20.7, but is fixed in 3.20.8 and later. (In reply to Frédéric Demians from comment #10) > I've already reverted this patch December 29th. So the bug reported on > mailing list is there in 3.20.7, but is fixed in 3.20.8 and later. Oops, sorry, I should have tested that! (In reply to Frédéric Demians from comment #9) Do you know why Jenkins don't run anymore tests for 3.20 branch. Tomas reported an issue on the jenkins config. I will ping him on #koha |