Bug 15185

Summary: 3 subroutines are unused in C4::Circulation
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: hector.hecaxmmx, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 15185: Remove Check*Holidays subroutines in C4::Circulation
[SIGNED-OFF]Bug 15185: Remove Check*Holidays subroutines in C4::Circulation
[PASSED QA] Bug 15185: Remove Check*Holidays subroutines in C4::Circulation

Description Jonathan Druart 2015-11-13 11:43:27 UTC

    
Comment 1 Jonathan Druart 2015-11-13 11:45:54 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2015-11-13 19:02:08 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2015-11-15 22:51:26 UTC
Created attachment 44870 [details] [review]
[PASSED QA] Bug 15185: Remove Check*Holidays subroutines in C4::Circulation

These 3 subroutines are not used anymore:
- CheckRepeatableHolidays
- CheckSpecialHolidays
- CheckRepeatableSpecialHolidays

Moreover we have subroutines in Koha::Calendar to do this job.

Test plan:
  git grep CheckRepeatableHolidays
  git grep CheckSpecialHolidays
  git grep CheckRepeatableSpecialHolidays
should not return any results.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Subroutines removed

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2015-11-17 13:07:13 UTC
Patch pushed to master.

Thanks Jonathan!