| Summary: | Perl scripts missing exec permission | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
| Component: | Architecture, internals, and plumbing | Assignee: | Fridolin Somers <fridolin.somers> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | bgkriegel, f.demians, hector.hecaxmmx, julian.maurice, kyle |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 15193 - Perl scripts missing exec permission
[SIGNED-OFF]Bug 15193: Perl scripts missing exec permission Bug 15193 - Perl scripts missing exec permission |
||
Created attachment 44874 [details] [review] Bug 15193 - Perl scripts missing exec permission Some perl scripts have 644 permissions instead of 755. I think some are special like install-CPAN.pl. This patch corrects some common perl scripts. I still find some scripts without execute permissions, is that ok? -rw-r--r-- 1 bgkriegel bgkriegel 266 Oct 15 18:51 ./kohaversion.pl -rw-r--r-- 1 bgkriegel bgkriegel 1287 Oct 15 18:51 ./selenium/PERL/Members/FilterMembers.pl -rw-r--r-- 1 bgkriegel bgkriegel 913 Oct 15 18:51 ./selenium/PERL/Members/AddMember.pl -rw-r--r-- 1 bgkriegel bgkriegel 1020 Oct 15 18:51 ./selenium/PERL/Members/Searchmember.pl -rw-r--r-- 1 bgkriegel bgkriegel 1529 Oct 15 18:51 ./install-CPAN.pl -rw-r--r-- 1 bgkriegel bgkriegel 13064 Oct 15 18:51 ./misc/load_testing/benchmark_staff.pl -rw-r--r-- 1 bgkriegel bgkriegel 5082 Oct 15 18:51 ./cataloguing/value_builder/EXAMPLE.pl -rw-r--r-- 1 bgkriegel bgkriegel 10593 Oct 15 18:51 ./koha-tmpl/intranet-tmpl/lib/tiny_mce/tiny_mce_gzip.pl (In reply to Bernardo Gonzalez Kriegel from comment #2) > I still find some scripts without execute permissions, > is that ok? > > -rw-r--r-- 1 bgkriegel bgkriegel 266 Oct 15 18:51 ./kohaversion.pl I don't see why it could not have execute permissions. > -rw-r--r-- 1 bgkriegel bgkriegel 1287 Oct 15 18:51 > ./selenium/PERL/Members/FilterMembers.pl > -rw-r--r-- 1 bgkriegel bgkriegel 913 Oct 15 18:51 > ./selenium/PERL/Members/AddMember.pl > -rw-r--r-- 1 bgkriegel bgkriegel 1020 Oct 15 18:51 > ./selenium/PERL/Members/Searchmember.pl Selenium is special I think, keep like this. > -rw-r--r-- 1 bgkriegel bgkriegel 1529 Oct 15 18:51 ./install-CPAN.pl This is like Makefile.PL, maybe not executable to avoid launching by mistake. > -rw-r--r-- 1 bgkriegel bgkriegel 13064 Oct 15 18:51 > ./misc/load_testing/benchmark_staff.pl May have execute permissions I'd say. > -rw-r--r-- 1 bgkriegel bgkriegel 5082 Oct 15 18:51 > ./cataloguing/value_builder/EXAMPLE.pl Maybe on purpose since it is a sample. > -rw-r--r-- 1 bgkriegel bgkriegel 10593 Oct 15 18:51 > ./koha-tmpl/intranet-tmpl/lib/tiny_mce/tiny_mce_gzip.pl This is an imported library so I'd say we don't change. Created attachment 45348 [details] [review] [SIGNED-OFF]Bug 15193: Perl scripts missing exec permission Some perl scripts have 644 permissions instead of 755. I think some are special like install-CPAN.pl. This patch corrects some common perl scripts. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Created attachment 45584 [details] [review] Bug 15193 - Perl scripts missing exec permission Some perl scripts have 644 permissions instead of 755. I think some are special like install-CPAN.pl. This patch corrects some common perl scripts. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master! Thanks Frido! Patch pushed to 3.22.x, will be in 3.22.1 This patch has been pushed to 3.20.x, will be in 3.20.7. |
Some perl scripts have 644 permissions instead of 755. I think some are special like install-CPAN.pl but others are incorrect for no reason : $ find . -name '*.pl' -exec ls -l {} \; | grep -v "rwx" -rw-rw-r-- 1 fsomers fsomers 4679 oct. 29 15:12 ./misc/cronjobs/nl-sync-from-koha.pl -rw-rw-r-- 1 fsomers fsomers 5697 oct. 29 15:12 ./misc/cronjobs/nl-sync-to-koha.pl -rw-rw-r-- 1 fsomers fsomers 13064 oct. 29 15:12 ./misc/load_testing/benchmark_staff.pl -rw-rw-r-- 1 fsomers fsomers 913 juil. 28 15:17 ./selenium/PERL/Members/AddMember.pl -rw-rw-r-- 1 fsomers fsomers 1287 juil. 28 15:17 ./selenium/PERL/Members/FilterMembers.pl -rw-rw-r-- 1 fsomers fsomers 1020 juil. 28 15:17 ./selenium/PERL/Members/Searchmember.pl -rw-rw-r-- 1 fsomers fsomers 10593 oct. 29 15:12 ./koha-tmpl/intranet-tmpl/lib/tiny_mce/tiny_mce_gzip.pl -rw-r--r-- 1 fsomers fsomers 266 nov. 13 12:28 ./kohaversion.pl -rw-r--r-- 1 fsomers fsomers 1529 nov. 10 16:54 ./install-CPAN.pl -rw-r--r-- 1 fsomers fsomers 3455 nov. 10 16:54 ./cataloguing/value_builder/unimarc_field_100_authorities.pl -rw-r--r-- 1 fsomers fsomers 11552 nov. 13 12:28 ./cataloguing/value_builder/marc21_linking_section.pl -rw-r--r-- 1 fsomers fsomers 5082 nov. 10 16:54 ./cataloguing/value_builder/EXAMPLE.pl