Summary: | In Rancor, multiple &/</" characters not escaped on saving | ||
---|---|---|---|
Product: | Koha | Reporter: | Jesse Weaver <jweaver> |
Component: | Cataloging | Assignee: | Jesse Weaver <jweaver> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | critical | ||
Priority: | P5 - low | CC: | m.de.rooy, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 15197: In Rancor, multiple &/</> characters not escaped on saving
Bug 15197: In Rancor, multiple &/</" characters not escaped on saving Bug 15197: In Rancor, multiple &/</" characters not escaped on saving [SIGNED-OFF] Bug 15197: In Rancor, multiple &/</" characters not escaped on saving [PASSED QA] Bug 15197: In Rancor, multiple &/</" characters not escaped on saving |
Description
Jesse Weaver
2015-11-16 21:41:58 UTC
Created attachment 44894 [details] [review] Bug 15197: In Rancor, multiple &/</> characters not escaped on saving Created attachment 44895 [details] [review] Bug 15197: In Rancor, multiple &/</" characters not escaped on saving Test plan: 1) On current master, create a record in Rancor containing multiple <, > or & characters ("A & B & C", for example). 2) Try to save the record, it will silently fail. 3) Apply this patch. 4) The record should now save correctly. (In reply to Jesse Weaver from comment #3) > Test plan: > > 1) On current master, create a record in Rancor containing multiple <, > > or & characters ("A & B & C", for example). > 2) Try to save the record, it will silently fail. > 3) Apply this patch. > 4) The record should now save correctly. Ugh, I shouldn't comment when tired. The characters in question are <, & and ". Created attachment 44896 [details] [review] Bug 15197: In Rancor, multiple &/</" characters not escaped on saving Test plan: 1) On current master, create a record in Rancor containing multiple &, < or " characters ("A & B & C", for example). 2) Try to save the record, it will silently fail. 3) Apply this patch. 4) The record should now save correctly. Created attachment 44897 [details] [review] [SIGNED-OFF] Bug 15197: In Rancor, multiple &/</" characters not escaped on saving Test plan: 1) On current master, create a record in Rancor containing multiple &, < or " characters ("A & B & C", for example). 2) Try to save the record, it will silently fail. 3) Apply this patch. 4) The record should now save correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works well, record saved No errors Created attachment 44905 [details] [review] [PASSED QA] Bug 15197: In Rancor, multiple &/</" characters not escaped on saving Test plan: 1) On current master, create a record in Rancor containing multiple &, < or " characters ("A & B & C", for example). 2) Try to save the record, it will silently fail. 3) Apply this patch. 4) The record should now save correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works well, record saved No errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patch pushed to master. Thanks Jonathan! |