Summary: | Remove Depreciation Errors due to misuse of UNIVERSAL in SIP/Sip/MsgType.pm | ||
---|---|---|---|
Product: | Koha | Reporter: | Colin Campbell <colin.campbell> |
Component: | SIP2 | Assignee: | Colin Campbell <colin.campbell> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | colin.campbell, f.demians, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Proposed patch
[SIGNED-OFF] Bug 15215: Remove warning due to misuse of UNIVERSAL [PASSED QA] Bug 15215: Remove warning due to misuse of UNIVERSAL |
Description
Colin Campbell
2015-11-19 12:04:40 UTC
Created attachment 44992 [details] [review] Proposed patch Easy to test Without patch compiling MsgType.pm (perl -wc C4/SIP/Sip/MsgType.pm) will give a depreciation warning about calling UNIVERSAL's methods or with perl 5.22 will abort compilation with message that UNIVERSAL does not export any methods With patch applied module should compile without the warning/error Created attachment 45037 [details] [review] [SIGNED-OFF] Bug 15215: Remove warning due to misuse of UNIVERSAL Calling UNIVERSAL's internal methods will cause a depreciation warning in perls less that 5.22 as of 5.22 the warning is a fatal error causing compilation to abort Replace the use UNIVERSAL with UNIVERSAL::can to work around the buggy construct perldoc UNIVERSAL::can for more info Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No more worning/error No qa errors Created attachment 45043 [details] [review] [PASSED QA] Bug 15215: Remove warning due to misuse of UNIVERSAL Calling UNIVERSAL's internal methods will cause a depreciation warning in perls less that 5.22 as of 5.22 the warning is a fatal error causing compilation to abort Replace the use UNIVERSAL with UNIVERSAL::can to work around the buggy construct perldoc UNIVERSAL::can for more info Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No more worning/error No qa errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patch pushed to master. Thanks Colin! This patch has been pushed to 3.20.x, will be in 3.20.6. |