Bug 15230

Summary:	Remove unused file circ/stats.pl from system
Product:	Koha	Reporter:	Marc Véron <veron>
Component:	Architecture, internals, and plumbing	Assignee:	Marc Véron <veron>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	trivial
Priority:	P5 - low	CC:	jonathan.druart, julian.maurice, kyle
Version:	Main
Hardware:	All
OS:	All
See Also:	http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2008
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Bug 15230: Remove unused file circ/stats.pl and stats.tt from system [SIGNED-OFF] Bug 15230: Remove unused file circ/stats.pl and stats.tt from system Bug 15230: Remove unused file circ/stats.pl and stats.tt from system

Description Marc Véron 2015-11-21 07:52:31 UTC

circ/stats.pl and koha-tmpl/intranet-tmpl/prog/en/modules/circ/stats.tt seem not to be used.

To verify: git grep '/stats.pl'

koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt:<!--   <li>    <a href="/cgi-bin/koha/circ/stats.pl?time=yesterday">Daily 
koha-tmpl/intranet-tmpl/prog/en/modules/circ/stats.tt:            <li><a href="/cgi-bin/koha/circ/stats.pl?time=yesterday">yesterday</a></l
koha-tmpl/intranet-tmpl/prog/en/modules/circ/stats.tt:            <li><a href="/cgi-bin/koha/circ/stats.pl?time=today">today</a></li>

The reference to stats.pl in circulation-home.tt is commented out.

Comment 1 Marc Véron 2015-11-21 15:57:02 UTC Comment hidden (obsolete)

Created attachment 45069 [details] [review]
Bug 15230: Remove unused file circ/stats.pl and stats.tt from system

This patch removes stats.pl and stats.tt from system.

To test:
- Verify that both files are not used and that the only reference in
  koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt
  is commented out.
- Apply patch
- Verify that the files are deleted and the reference is removed.
- git grep 'stats.pl', verify that there are no more references to
  this file.

Comment 2 Owen Leonard 2015-11-24 16:14:20 UTC Comment hidden (obsolete)

Created attachment 45123 [details] [review]
[SIGNED-OFF] Bug 15230: Remove unused file circ/stats.pl and stats.tt from system

This patch removes stats.pl and stats.tt from system.

To test:
- Verify that both files are not used and that the only reference in
  koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt
  is commented out.
- Apply patch
- Verify that the files are deleted and the reference is removed.
- git grep 'stats.pl', verify that there are no more references to
  this file.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Comment 3 Jonathan Druart 2015-11-25 15:52:33 UTC

Created attachment 45148 [details] [review]
Bug 15230: Remove unused file circ/stats.pl and stats.tt from system

This patch removes stats.pl and stats.tt from system.

To test:
- Verify that both files are not used and that the only reference in
  koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt
  is commented out.
- Apply patch
- Verify that the files are deleted and the reference is removed.
- git grep 'stats.pl', verify that there are no more references to
  this file.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
See the following commit for more info on this script:
  commit 60105bd692a07639f275543365acfca4f464c1a2
  Date:   Tue Jul 8 20:02:34 2008 -0500
    fix for 2008: Daily reconciliation report broken

Comment 4 Kyle M Hall (khall) 2015-12-11 16:48:52 UTC

Pushed to master!

Thanks Marc!

Comment 5 Julian Maurice 2015-12-14 07:43:46 UTC

Patch pushed to 3.22.x, will be in 3.22.1