Bug 1528

Summary: phase in guided_reports.pl
Product: Koha Reporter: Paul Poulain <paul.poulain>
Component: ReportsAssignee: Chris Cormack <chris>
Status: CLOSED FIXED QA Contact:
Severity: blocker    
Priority: PATCH-Sent (DO NOT USE) CC: jonathan.druart
Version: Main   
Hardware: PC   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Crowdfunding committed: 0
Crowdfunding contact: Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 15280: Switch default CHECKOUT notice to Template Toolkit

Description Chris Cormack 2010-05-21 00:31:29 UTC


---- Reported by paul.poulain@biblibre.com 2007-10-30 08:45:21 ----

<input type="submit" name="phase" value="Build new"/>
in the template is associated with 

elsif ( $phase eq 'Build new' ) {
in the code.

Unfortunatly, the "Build new" is a string that is translated.
Thus, in the code, the $phase has no meaningful value, the guided reports don't work at all (sorry :\ )



---- Additional Comments From chris@bigballofwax.co.nz 2007-10-30 10:21:15 ----

Ill change these to hidden inputs, then the translating of the buttons wont break things.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 00:31 UTC  ---

This bug was previously known as _bug_ 1528 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=1528

Actual time not defined. Setting to 0.0

Comment 1 Jonathan Druart 2018-10-03 14:52:15 UTC
Created attachment 79895 [details] [review]
Bug 15280: Switch default CHECKOUT notice to Template Toolkit

Test Plan:
1) Ensure dependancies are applied
2) Apply this patch
3) Update your CHECKOUT notice to match the following:

The following items have been checked out:
----
[% biblio.title %]
----
Thank you for visiting [% branch.branchname %].

3) Generate a CHECKOUT notice for a patron
4) Note there is not change to the generated notice

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>