|
Description
Owen Leonard
2015-12-04 14:44:37 UTC
Created attachment 46388 [details] [review] Bug 15306: Do not display the translate link if only 1 language is installed It doesn't make sense to offer the option to translate an item type description into another language if there is only one language installed. Test plan: Enable only 1 language at the OPAC and the intranet. Edit an item type and confirm that the link "translate into..." is not displayed. Enable 1+ languages at the intranet and 1 at the opac, confirm that the link is displayed. Enable 1 language at the intranet and 1+ at the opac, confirm that the link is displayed. Enable 1+ language at the intranet and 1+ at the opac, confirm that the link is displayed. Another version of the patch could be provided to apply on top of 3.22. I'm not sure about taking enabled languages as a trigger for displaying the translation link. Use case for a country with multiple languages: - I have an installation with let's say English, German, French, Italian - English is and German are enabled. - Now I want to prepare my installation for French and / or Italian. I do all the translation work, but do not yet want to enbale the languages until I'm finished, e.g. because everithing has to be reviewed befor the new language is officially launched. With this patch, the translations would be have to be already visible while translating. Alternative: Use the _installed_ language as a trigger. Created attachment 46391 [details] [review] [ALTERNATIVE-PATCH] Bug 15306: Do not display the translate link if only 1 language is installed It doesn't make sense to offer the option to translate an item type description into another language if there is only one language installed. Test plan: Generates templates for only 1 language Edit an item type and confirm that the link "translate into..." is not displayed. Generates templates for another language Confirm that the link is now displayed. Created attachment 46394 [details] [review] Bug 15306: Do not display the translate link if only 1 language is installed It doesn't make sense to offer the option to translate an item type description into another language if there is only one language installed. Test plan: Generates templates for only 1 language Edit an item type and confirm that the link "translate into..." is not displayed. Generates templates for another language Confirm that the link is now displayed. Works as expected. Tested with English only installed. Signed-off-by: Marc Véron <veron@veron.ch> @Owen: What do you think, is the alternative patch OK for you? Comment on attachment 46394 [details] [review] Bug 15306: Do not display the translate link if only 1 language is installed I think my sign-off here was on the alternative patch, but to make it sure I obsolete this one and sgn-off again on the alternative patch. Created attachment 46480 [details] [review] [ALTERNATIVE-PATCH] Bug 15306: Do not display the translate link if only 1 language is installed It doesn't make sense to offer the option to translate an item type description into another language if there is only one language installed. Test plan: Generates templates for only 1 language Edit an item type and confirm that the link "translate into..." is not displayed. Generates templates for another language Confirm that the link is now displayed. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 46483 [details] [review] Bug 15306: Do not display the translate link if only 1 language is installed It doesn't make sense to offer the option to translate an item type description into another language if there is only one language installed. Test plan: Generates templates for only 1 language Edit an item type and confirm that the link "translate into..." is not displayed. Generates templates for another language Confirm that the link is now displayed. Signed-off-by: Marc Véron <veron@veron.ch> Just removed a trailing warn Created attachment 46764 [details] [review] [PASSED QA] Bug 15306: Do not display the translate link if only 1 language is installed It doesn't make sense to offer the option to translate an item type description into another language if there is only one language installed. Test plan: Generates templates for only 1 language Edit an item type and confirm that the link "translate into..." is not displayed. Generates templates for another language Confirm that the link is now displayed. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to Master - Should be in the May 2016 Release. Thanks Patch pushed to stable, will be in 3.22.5 |