Summary: | Add delete report option to Show, Edit and Run screens | ||
---|---|---|---|
Product: | Koha | Reporter: | HB-NEKLS <gwilliams> |
Component: | Reports | Assignee: | Magnus Enger <magnus> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | jonathan.druart, kyle, magnus |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 15321 - Add delete report link to Show, Edit and Run screens
Bug 15321 - Add delete report link to Show, Edit and Run screens Bug 15321 - Add delete report link to Show, Edit and Run screens Bug 15321: No need to add the change trigger conditionally Bug 15321: No need to add the change trigger conditionally |
Description
HB-NEKLS
2015-12-06 02:23:11 UTC
*** Bug 15322 has been marked as a duplicate of this bug. *** Because of the way the relevant templates are structured, it is easy to add the Delete link to the Show, Edit and Run screens in one go, so I have marked bug 15322 as a duplicate of this one. Created attachment 45509 [details] [review] Bug 15321 - Add delete report link to Show, Edit and Run screens Currently, if you are editing or viewing the results of running a report and you decide you want to delete it, you have to go back to the list of saved reports to do so. This patch adds a "Delete" link in some convenient places. To test: - Apply the patch - Make sure you have at least one saved report - Make sure you have the create_reports permission - Go to the Show, Edit and Run screens and verify the Delete link is present and functional - Change to a user without the create_reports permission and check that the Delete link is not displayed on the Show, Edit and Run screens - Sign ye off merrily! Magnus, you just made my day with this! I've tested it, to check for it in the three places (edit, "report has been saved", and run screens), and it's present in all three places. Before signing off, though, I did notice there's no delete confirmation message appearing -- the reports just delete. Can that be fixed in the scope of this bug or does it need to be a separate bug report? Ah, when you click Delete from the list of saved reports there is a JavaScript confirmation that I missed. I'll see if I can get that to work with the new links. Created attachment 45513 [details] [review] Bug 15321 - Add delete report link to Show, Edit and Run screens Currently, if you are editing or viewing the results of running a report and you decide you want to delete it, you have to go back to the list of saved reports to do so. This patch adds a "Delete" link in some convenient places. To test: - Apply the patch - Make sure you have at least one saved report - Make sure you have the create_reports permission - Go to the Show, Edit and Run screens and verify the Delete link is present and functional, including the JavaScript confirmation dialogue - Change to a user without the create_reports permission and check that the Delete link is not displayed on the Show, Edit and Run screens - Sign ye off merrily! Version 2: This version makes sure the JavaScript confirmation is shown before an actual delete is carried out. I've followed the testing plan below, including the patch update in version 2, and this works as described. Thanks Magnus! Test plan: - Apply the patch - Make sure you have at least one saved report - Make sure you have the create_reports permission - Go to the Show, Edit and Run screens and verify the Delete link is present and functional, including the JavaScript confirmation dialogue - Change to a user without the create_reports permission and check that the Delete link is not displayed on the Show, Edit and Run screens - Sign ye off merrily! Version 2: This version makes sure the JavaScript confirmation is shown before an actual delete is carried out. Created attachment 45518 [details] [review] Bug 15321 - Add delete report link to Show, Edit and Run screens Currently, if you are editing or viewing the results of running a report and you decide you want to delete it, you have to go back to the list of saved reports to do so. This patch adds a "Delete" link in some convenient places. To test: - Apply the patch - Make sure you have at least one saved report - Make sure you have the create_reports permission - Go to the Show, Edit and Run screens and verify the Delete link is present and functional, including the JavaScript confirmation dialogue - Change to a user without the create_reports permission and check that the Delete link is not displayed on the Show, Edit and Run screens - Sign ye off merrily! Version 2: This version makes sure the JavaScript confirmation is shown before an actual delete is carried out. Signed-off-by: Heather Braum <hbraum@nekls.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 45519 [details] [review] Bug 15321: No need to add the change trigger conditionally It will be applied with the button exists. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 45520 [details] [review] Bug 15321: No need to add the change trigger conditionally It will be applied if the button exists. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master, thanks Magnus! |