Bug 15346

Summary: Translatability: fix sentence splitting issue in memberentrygen.tt
Product: Koha Reporter: Marc Véron <veron>
Component: I18N/L10NAssignee: Marc Véron <veron>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: brendan, f.demians, hector.hecaxmmx, julian.maurice
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: String patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 15346: Translatability: fix sentence splitting issue in memberentrygen.tt
[SIGNED-OFF]Bug 15346: Translatability: fix sentence splitting issue in memberentrygen.tt
Bug 15346: Translatability: fix sentence splitting issue in memberentrygen.tt
Bug 15346: Translatability: fix sentence splitting issue in memberentrygen.tt

Description Marc Véron 2015-12-09 20:30:49 UTC
Fix sentences in memberentrygen.tt that are split by <strong> tags, leading to wrong capitalization in German (because it can not be decided if a string is part of a sentence or a standalone sentence).
Example: Es sind Keine Bibliotheken definiert.
Comment 1 Marc Véron 2015-12-09 20:40:05 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2015-12-10 01:50:55 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2015-12-10 12:04:09 UTC Comment hidden (obsolete)
Comment 4 Brendan Gallagher 2015-12-29 20:26:56 UTC
Created attachment 46029 [details] [review]
Bug 15346: Translatability: fix sentence splitting issue in memberentrygen.tt

Fix sentences in memberentrygen.tt that are split by <strong> tags, leading to
wrong capitalization in German (because it can not be decided if a string is part
of a sentence or a standalone sentence).
Example: Es sind Keine Bibliotheken definiert.

To test:
- Apply patch
- To trigger the messages, you have to edit a patron in a system where
  no libraries and no patron categories are defined
- Alternatively, carefully review the changes in
  koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Sentences fixed for translation purposes

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
Comment 5 Brendan Gallagher 2015-12-29 20:27:37 UTC
Pushed to Master - Thanks!
Comment 6 Julian Maurice 2015-12-30 16:00:29 UTC
Patch pushed in 3.22.x, will be in 3.22.2
Comment 7 Frédéric Demians 2015-12-31 18:23:39 UTC
This patch has been pushed to 3.20.x, will be in 3.20.8.