Summary: | Remove 'lost' items from course reserves | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Course reserves | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Josef Moravec <josef.moravec> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | jonathan.druart, josef.moravec, kyle, nicolas.legrand, sandboxes, severine.queune, tmisilo |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | Sponsored | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 15378: Allow removal of lost items from course reserves
Bug 15378: Allow removal of lost items from course reserves Bug 15378: Allow removal of lost items from course reserves |
Description
Nick Clemens (kidclamp)
2015-12-15 14:16:59 UTC
I'm working on a cosmetic change to this template, and it looks like the prevention of lost item removal is controlled by template logic. It doesn't appear that there is any real problem removing lost items from course reserves. Kyle, if you could confirm that there isn't an unseen side effect of removing lost items I will submit a patch enabling it. The BULAC (http://www.bulac.fr/) would like to sponsore this development. Nick, Kyle, did you work further on the patch ? As long as “Change sponsored?” is set on “Seeking developer”, anyone wanting to quote us for the development of such a feature or just ask for more information is welcome to write to us: <sigb@bulac.fr>. Created attachment 68033 [details] [review] Bug 15378: Allow removal of lost items from course reserves It seems that this restriction is not necessary, it should be possible to remove lost items from course reserves. Test plan: Create a course and add reserve with a lost item => Without this patch the "Remove" button is disabled and the item cannot be removed from the course => With this patch applied the button is enable and the item can be removed Patch tested with a sandbox, by Séverine QUEUNE <severine.queune@bulac.fr> Created attachment 68071 [details] [review] Bug 15378: Allow removal of lost items from course reserves It seems that this restriction is not necessary, it should be possible to remove lost items from course reserves. Test plan: Create a course and add reserve with a lost item => Without this patch the "Remove" button is disabled and the item cannot be removed from the course => With this patch applied the button is enable and the item can be removed Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Items can now be removed of a course reserve applying this patch. The value of lost status is untouched. Thanks Jonathan ! Created attachment 70225 [details] [review] Bug 15378: Allow removal of lost items from course reserves It seems that this restriction is not necessary, it should be possible to remove lost items from course reserves. Test plan: Create a course and add reserve with a lost item => Without this patch the "Remove" button is disabled and the item cannot be removed from the course => With this patch applied the button is enable and the item can be removed Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Pushed to master for 18.05, thanks to everybody involved! |