Summary: | Checkout / patron pages: Hide menu items leading to 404 page | ||
---|---|---|---|
Product: | Koha | Reporter: | Marc Véron <veron> |
Component: | Staff interface | Assignee: | Marc Véron <veron> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, julian.maurice, kyle, lmoraes |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 15386: Checkout / patron pages: Hide menu items leading to 404 pages
Bug 15386: Checkout / patron pages: Hide menu items leading to 404 pages |
Description
Marc Véron
2015-12-16 14:59:50 UTC
Created attachment 45726 [details] [review] Bug 15386: Checkout / patron pages: Hide menu items leading to 404 pages Some of the menu items on patron / Checkout related pages lead to a 404 page depending on the permissions. This patch hides them as appropriate. To test: - For a staff member A, set permission 'borrowers' only (+ 'catalogue') - Log in as A - Search a patron and display details - Verify that none of the menu items at the left lead to the 404 page - For a staff member B, set permission 'circulate_remaining_permission' only (+ catalogue) - Log in as B - Go to Circulation > Checkout, search a patron - Click menu items at the left, some of them lead to the 404 page - Verify that none of the menu items at the left lead to the 404 page - Do the same for a staff member C with both permissions set - Verify that menu items appear as expected Looks like ok Bug 15386: Checkout / patron pages: Hide menu items leading to 404 pages Some of the menu items on patron / Checkout related pages lead to a 404 page depending on the permissions. This patch hides them as appropriate. To test: - For a staff member A, set permission 'borrowers' only (+ 'catalogue') - Log in as A - Search a patron and display details - Verify that none of the menu items at the left lead to the 404 page - For a staff member B, set permission 'circulate_remaining_permission' only (+ catalogue) - Log in as B - Go to Circulation > Checkout, search a patron - Click menu items at the left, some of them lead to the 404 page - Verify that none of the menu items at the left lead to the 404 page - Do the same for a staff member C with both permissions set - Verify that menu items appear as expecte Signed-off-by: Lucio Moraes <lmoraes@catalyst.net.nz> Created attachment 45987 [details] [review] Bug 15386: Checkout / patron pages: Hide menu items leading to 404 pages Some of the menu items on patron / Checkout related pages lead to a 404 page depending on the permissions. This patch hides them as appropriate. To test: - For a staff member A, set permission 'borrowers' only (+ 'catalogue') - Log in as A - Search a patron and display details - Verify that none of the menu items at the left lead to the 404 page - For a staff member B, set permission 'circulate_remaining_permission' only (+ catalogue) - Log in as B - Go to Circulation > Checkout, search a patron - Click menu items at the left, some of them lead to the 404 page - Verify that none of the menu items at the left lead to the 404 page - Do the same for a staff member C with both permissions set - Verify that menu items appear as expected Signed-off-by: Lucio Moraes <lmoraes@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Amended patch: I have remove the double if CAN_user_circulate_circulate_remaining_permissions statement (and group block into one). And also remove unecessary change ('IF a IF b' instead of existing 'IF a && b') Pushed to master, thanks Marc! Patch pushed to 3.22.x, will be in 3.22.2 |