Summary: | Warns on Guided Reports page | ||
---|---|---|---|
Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
Component: | Reports | Assignee: | Aleisha Amohia <aleisha> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | brendan, f.demians, hector.hecaxmmx, jonathan.druart, julian.maurice |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 15416: Warns on guided_reports.pl
[SIGNED-OFF]Bug 15416: Warns on guided_reports.pl Bug 15416: Warns on guided_reports.pl |
Description
Aleisha Amohia
2015-12-22 23:43:33 UTC
Created attachment 46761 [details] [review] Bug 15416: Warns on guided_reports.pl Initialising $phase variable to be '' if not defined. To test: 1) Go to Reports -> Guided Reports Wizard 2) Notice warns 3) Apply patch 4) Refresh page 5) Confirm warns are gone and page still works as it should Hi Aleisha I can't reproduce the issue, could you please confirm? This is still valid for me on version 3.23 of Koha (In reply to Aleisha Amohia from comment #3) > This is still valid for me on version 3.23 of Koha Pardon me I didn't know that i needed to consult the log files. Created attachment 47568 [details] [review] [SIGNED-OFF]Bug 15416: Warns on guided_reports.pl Initialising $phase variable to be '' if not defined. To test: 1) Go to Reports -> Guided Reports Wizard 2) Notice warns 3) Apply patch 4) Refresh page 5) Confirm warns are gone and page still works as it should Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Warns are gone. Page still works as expected Created attachment 47579 [details] [review] Bug 15416: Warns on guided_reports.pl Initialising $phase variable to be '' if not defined. To test: 1) Go to Reports -> Guided Reports Wizard 2) Notice warns 3) Apply patch 4) Refresh page 5) Confirm warns are gone and page still works as it should Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Warns are gone. Page still works as expected Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Amended patch: -my $phase = $input->param('phase'); -$phase //= ''; +my $phase = $input->param('phase') // ''; Pushed to Master - Should be in the May 2016 release. Thanks! Patch pushed to 3.22.x, will be in 3.22.4 This patch has been pushed to 3.20.x, will be in 3.20.9. |