Bug 15447

Summary: log4perl.conf does not have __LOG_DIR__ replaced when installing
Product: Koha Reporter: Kyle M Hall <kyle>
Component: Architecture, internals, and plumbingAssignee: Kyle M Hall <kyle>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: blocker    
Priority: P5 - low CC: jonathan.druart, julian.maurice
Version: unspecified   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16084
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 15447 - log4perl.conf does not have __LOG_DIR__ replaced when installing
Bug 15447 - log4perl.conf does not have __LOG_DIR__ replaced when installing

Description Kyle M Hall 2015-12-30 18:55:18 UTC
Since the introduction of Koha::Logger, it appears that the log4perl.conf config file has been broken. The references to __LOG_DIR__ is not being replaced.
Comment 1 Kyle M Hall 2015-12-30 19:00:11 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2015-12-31 11:30:38 UTC
Created attachment 46119 [details] [review]
Bug 15447 - log4perl.conf does not have __LOG_DIR__ replaced when installing

Since the introduction of Koha::Logger, it appears that the
log4perl.conf config file has been broken. The references to __LOG_DIR__
is not being replaced.

Test Plan:
1) Apply this patch
2) Run 'perl Makefile.PL'
3) Run 'make'
4) Open blib/KOHA_CONF_DIR/log4perl.conf with a text editor
5) Note the log file paths are correctly set, and do not have
   __LOG_DIR__ in them.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 3 Jonathan Druart 2015-12-31 11:31:00 UTC
Trivial, skipping QA.
Comment 4 Kyle M Hall 2015-12-31 11:41:08 UTC
Pushed to master!
Comment 5 Julian Maurice 2016-01-03 10:29:10 UTC
Patch pushed to 3.22.x, will be in 3.22.2