| Summary: | view_holdsqueue.tt uses a search for cardnumber instead of borrowernumber direct link | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Circulation | Assignee: | Bugs List <koha-bugs> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | gmcharlt, jonathan.druart, kyle, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Crowdfunding committed: | 0 |
| Crowdfunding contact: | Patch complexity: | --- | |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
|
Description
Nick Clemens (kidclamp)
2016-01-04 22:26:13 UTC
I don't understand what is the problem here. It seems like we add a call to GetMember to get the borrowernumber from the cardnumber when we could just as easily provide the borrowernumber directly. Maybe it doesn't have an impact, just feels like it would be more clean the other way. (In reply to Jonathan Druart from comment #1) > I don't understand what is the problem here circ/circulation.pl expects a cardnumber:
246 if ($findborrower) {
247 my $borrower = C4::Members::GetMember( cardnumber => $findborrower );
248 if ( $borrower ) {
249 $borrowernumber = $borrower->{borrowernumber};
250 } else {
If not found, the script will try and search the $findborrower using the C4::Utils::DataTables::Members::search subroutine.
We will have to change all occurrences if we want to change this behavior, not only view_holdsqueue.tt
It look slike this has been resovled, maybe with another patch set: /cgi-bin/koha/circ/circulation.pl?borrowernumber=51#reserves |