Bug 15470

Summary:	Error when adding new authority with Default framework
Product:	Koha	Reporter:	Frédéric Demians <f.demians>
Component:	Templates	Assignee:	Frédéric Demians <f.demians>
Status:	RESOLVED DUPLICATE	QA Contact:	Testopia <testopia>
Severity:	major
Priority:	P5 - low	CC:	bgkriegel, jonathan.druart
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Bug Depends on:	15381
Bug Blocks:
Attachments:	Bug 15470: Error when adding new authority with Default framework [SIGNED-OFF] Bug 15470: Error when adding new authority with Default framework

Description Frédéric Demians 2016-01-05 11:45:06 UTC

To produce this bug: Authorities > New authority > Default

Result: Can't call method "authtypetext" on an undefined value at /home/tamil/client/devel/kohaclone/authorities/authorities.pl line 665.

Comment 1 Frédéric Demians 2016-01-05 11:48:20 UTC Comment hidden (obsolete)

Created attachment 46250 [details] [review]
Bug 15470: Error when adding new authority with Default framework

TO TEST:
1. Authorities > New authority > Default
2. You get:
   Can't call method "authtypetext" on an undefined value at
3. Apply the patch and repeat 1

Comment 2 Bernardo Gonzalez Kriegel 2016-01-05 15:22:52 UTC

Created attachment 46267 [details] [review]
[SIGNED-OFF] Bug 15470: Error when adding new authority with Default framework

TO TEST:
1. Authorities > New authority > Default
2. You get:
   Can't call method "authtypetext" on an undefined value at
3. Apply the patch and repeat 1

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Bug reproduced, now fixed.
No koha-qa errors

Comment 3 Bernardo Gonzalez Kriegel 2016-01-05 15:31:51 UTC

Hi,
I signed this, but seems to be  duplicate of Bug 15473,
can you take a look?

Comment 4 Jonathan Druart 2016-01-05 15:32:40 UTC

Frédéric,

Sorry I have noticed before but actually it's a duplicate of bug 15473 (I have just filled).
With your patch, we are loosing the 'Default' authtypetext.

I am marking this one as a duplicate as I am pretty sure it's the way to go.

Comment 5 Jonathan Druart 2016-01-05 15:33:00 UTC


*** This bug has been marked as a duplicate of bug 15473 ***

Comment 6 Frédéric Demians 2016-01-05 15:48:13 UTC

(In reply to Jonathan Druart from comment #4)
> Frédéric,
> 
> Sorry I have noticed before but actually it's a duplicate of bug 15473 (I
> have just filled).
> With your patch, we are loosing the 'Default' authtypetext.
> 
> I am marking this one as a duplicate as I am pretty sure it's the way to go.

I agree