Bug 15546

Summary: Software Error for all access to Label Creator
Product: Koha Reporter: Charlotte Stock <library>
Component: Label/patron card printingAssignee: Chris Nighswonger <cnighswonger>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: jonathan.druart, mjr
Version: 3.18   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:

Description Charlotte Stock 2016-01-11 14:50:20 UTC
This software error message appears for each option selected in Label Creator. I am able to create a new template but when 'save' is selected, again the error message appears. Please advise.
Comment 1 Charlotte Stock 2016-01-11 14:50:46 UTC
Software error:

Can't use string ("-1") as an ARRAY ref while "strict refs" in use at /usr/share/koha/intranet/cgi-bin/labels/label-edit-template.pl line 120.

For help, please send mail to the webmaster ([no address given]), giving this error message and the time and date of the error.
Comment 2 Jonathan Druart 2016-01-11 15:39:18 UTC
You should have an error in your Koha log file, do you have access to it?
Comment 3 MJ Ray (software.coop) 2016-02-12 17:19:59 UTC
The co-op fixed this. To summarise:

The log file included "Table 'koha_library.creator_layouts' doesn't exist"

It seems that labels_upgrade.pl did not run successfully during an upgrade back in the mists of time and updatedatabase.pl does not check its exit status.

As a consequence, patroncards_upgrade.pl did not run successfully either.

The database structure has been fixed by reading those and kohastructure.sql and now the label creator does not produce this error.

I will mark this as FIXED and leave it up to others to decide whether it's a bug that updatedatabase.pl doesn't check the exit status of extra upgrade scripts.