| Summary: | circ/renew.pl is broken | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Circulation | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | aleisha, f.demians, gmcharlt, gwilliams, janet.mcgowan, julian.maurice, jweaver, kyle.m.hall, kyle |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 11944 | ||
| Bug Blocks: | 15581 | ||
| Attachments: |
Bug 15570: (follow-up) Bug 11944 Remove all utf8 filter from templates
Bug 15570: (follow-up) Bug 11944 Remove all utf8 filter from templates [PASSED QA] Bug 15570: (follow-up) Bug 11944 Remove all utf8 filter from templates |
||
|
Description
Jonathan Druart
2016-01-13 17:50:54 UTC
Created attachment 46614 [details] [review] Bug 15570: (follow-up) Bug 11944 Remove all utf8 filter from templates Test plan: use circ/renew.pl to renew an issue. Without this patch, you will get an error. Note: The error exists for 1 year now and nobody complained?? Does someone still use this script? (In reply to Jonathan Druart from comment #1) > Created attachment 46614 [details] [review] [review] > Bug 15570: (follow-up) Bug 11944 Remove all utf8 filter from templates > > Test plan: > use circ/renew.pl to renew an issue. > Without this patch, you will get an error. > > Note: The error exists for 1 year now and nobody complained?? Does > someone still use this script? Yes, the library that sponsored the feature is still on an older stable release. Kyle beat me to commenting -- I just checked it on 3.18.12 and it's still working as expected, hence no complaints yet! Only our school libraries are using the feature, as far as I know. They would have let me know if it was broken. I haven't started testing 3.22 yet (coming soon), but will definitely be tracking this bug. circ/renew.pl is not working for me, i keep getting this error: Can't call method "single" without a package or object reference at /home/vagrant/kohaclone/circ/renew.pl line 57. Aleisha, update your repo, this error has been fixed by bug 15462. Created attachment 46660 [details] [review] Bug 15570: (follow-up) Bug 11944 Remove all utf8 filter from templates Test plan: use circ/renew.pl to renew an issue. Without this patch, you will get an error. Note: The error exists for 1 year now and nobody complained?? Does someone still use this script? Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 46762 [details] [review] [PASSED QA] Bug 15570: (follow-up) Bug 11944 Remove all utf8 filter from templates Test plan: use circ/renew.pl to renew an issue. Without this patch, you will get an error. Note: The error exists for 1 year now and nobody complained?? Does someone still use this script? Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master. Thanks for your work. Patch pushed to 3.22.x, will be in 3.22.2 This patch has been pushed to 3.20.x, will be in 3.20.8. |