|
Description
Owen Leonard
2016-01-19 16:53:54 UTC
Created attachment 46976 [details] [review] Bug 15602 - Accessibility: Can't tab to add link in patron card creator add patrons popup To Test - 1. Go onto Tools and then click on Patron Card Creator. 2. Click on New and then Card Batch. 3. Add a borrowernumber then add patron. 4. Search for a patron. 5. Using the tab key try to navigate onto the Add link. 6. Notice it skips Add. 7. Apply the patch and then repeat steps 1-5, notice the add link can now be accessed through using the keyboard. I got this error: Software error: Can't call method "get_attr" without a package or object reference at /home/koha/kohaclone/patroncards/edit-batch.pl line 137. But isn't your patch the problem here! (In reply to Héctor Eduardo Castro Avalos from comment #2) > I got this error: > > Software error: > > Can't call method "get_attr" without a package or object reference at > /home/koha/kohaclone/patroncards/edit-batch.pl line 137. > > But isn't your patch the problem here! Ok the error is lauched when NO LIBRARY IS SET, i.e., when you're using the koha db admin user. Created attachment 47140 [details] [review] [SIGNED-OFF]Bug 15602: Accessibility: Can't tab to add link in patron card creator add patrons popup To Test - 1. Go onto Tools and then click on Patron Card Creator. 2. Click on New and then Card Batch. 3. Add a borrowernumber then add patron. 4. Search for a patron. 5. Using the tab key try to navigate onto the Add link. 6. Notice it skips Add. 7. Apply the patch and then repeat steps 1-5, notice the add link can now be accessed through using the keyboard. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described. Created attachment 47160 [details] [review] Bug 15602: Accessibility: Can't tab to add link in patron card creator add patrons popup To Test - 1. Go onto Tools and then click on Patron Card Creator. 2. Click on New and then Card Batch. 3. Add a borrowernumber then add patron. 4. Search for a patron. 5. Using the tab key try to navigate onto the Add link. 6. Notice it skips Add. 7. Apply the patch and then repeat steps 1-5, notice the add link can now be accessed through using the keyboard. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 47161 [details] [review] Bug 15602: Remove cursor:pointer With the href attribute, the cusor will be displayed as a pointer. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - Should be in the May 2016 Release. Thanks! Patch pushed to 3.22.x, will be in 3.22.2 This patch has been pushed to 3.20.x, will be in 3.20.8. |