Bug 15617

Summary: Be able to close "Click to edit" text boxes after opening them
Product: Koha Reporter: Aleisha Amohia <aleisha>
Component: System AdministrationAssignee: Gus Ellerm <ellermaugustus>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: brendan, ellermaugustus, gmcharlt
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Small patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Click to edit text box on syspref
15617 - Be able to close "Click to edit" text boxes after opening them Test - 1. Go to admin preferences, Acquisitions, Policy. 2. Find MarcFieldsToOrder and click "Click to Edit" 3. Notice that a "Click to collapse" button appears, click it. 4. Notice th
15617 - Be able to close "Click to edit" text boxes after opening them Test
[SIGNED-OFF] 15617 - Be able to close "Click to edit" text boxes after opening them
15617 - Be able to close "Click to edit" text boxes after opening them

Description Aleisha Amohia 2016-01-19 22:35:59 UTC
Created attachment 46953 [details]
Click to edit text box on syspref

I think that once you have opened a 'Click to edit' text box, you should be able to click a 'Cancel' or 'Hide' button and close it again. I realise you are able to collapse the box down by dragging the corner, but it would be nice to have a show and hide function.

Leaving for someone better at javascript than me to figure out.

I think preferences.tt and systempreferences.tt are the only files that have 'Click to edit' text boxes.
Comment 1 Gus Ellerm 2016-01-20 23:51:33 UTC Comment hidden (obsolete)
Comment 2 Gus Ellerm 2016-01-21 00:47:58 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2016-01-21 14:57:14 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2016-01-21 15:17:49 UTC
Created attachment 47132 [details] [review]
15617 - Be able to close "Click to edit" text boxes after opening them

To test:

1. Go to admin preferences, Acquisitions, Policy.
2. Find MarcFieldsToOrder and click "Click to Edit"
3. Notice that a "Click to collapse" button appears, click it.
4. Notice that the box has collapsed

This fix should be applicable to all "Click to Edit" textboxes

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Works well, and a nice improvement.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Brendan Gallagher 2016-01-27 05:33:42 UTC
Pushed to Master - Should be in the May 2016 release. Thanks!