Bug 15647

I can provide some background on this.

The Reply-to and Return-Path addresses were added to combat a problem with emails being rejected or flagged as spam if the library used an email address with a different domain than that of the Koha server. (The KohaAdminEmailAddress, or library Email address if set, is what shows up in the 'From' header, and is what is checked by many spam filters, and for checking SPF records.)

This is especially important for sites like ours, where the library wants to use one of their own addresses for email, and be able to get replies and bouncebacks, but their Koha installation is hosted on a server in the vendor's domain. So we might use something like 'no_reply@site.servername.com' in the KohaAdminEmailAddress or the branchemail, so the messages will get delivered, and not rejected as spam.

However, print notices are hard coded to be sent to either the branchemail or the KohaAdminEmailAddress. So the 'gotcha' is you need to use an address in the same domain as the server to avoid rejects, but if you do, then the library may not be able to get their print notices email.

This bug requests the option to choose one of the other addresses (Reply-to or Return-path) as the place to send the print notices emails.

Created attachment 47235 [details] [review]
Bug 15647: Allow selection of destination email address for print overdue notices

Test plan:

  * Verify that, after patch, print overdue notices are still sent to
    branchemail/KohaAdminEmailAddress as appropriate.
  * Change PrintNoticesEmailField to reply-to/return-path, and check
    that branchreplyto/ReplytoDefault or
    branchreturnpath/ReturnpathDefault (respectively) are used instead.

Additional setup hint for test plan:

Set different email addresses for ReplytoDefault and ReturnpathDefault, and for branchreplyto and branchreturnpath for one branch, so that it can be verified that the correct email addresses are being selected and the fallback-to-syspref mechanism is working correctly.

Hi all,

I know exactly what you are talking about... the general problem is that with the specific setup described, the branchemail is not the email of the library. This causes problems with the print overdues sent by overdue_notices.pl, but also in other places. 2 things we have run into so far:

- the admin email shown on the error pages
- the HOLDPLACED email

Should we deal with those separately or maybe have a general setting to determine which is the email address emails 'to the library' should be sent to?

Patch doesn't apply

Some problems occurred applying patches from bug 15647:
<h1>Something went wrong !</h1>Applying: Bug 15647: Allow selection of destination email address for print overdue notices
Using index info to reconstruct a base tree...
	Koha/Library.pm
	installer/data/mysql/sysprefs.sql
	koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
	misc/cronjobs/overdue_notices.pl
Falling back to patching base and 3-way merge...
Auto-merging misc/cronjobs/overdue_notices.pl
CONFLICT (content): Merge conflict in misc/cronjobs/overdue_notices.pl
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
Auto-merging installer/data/mysql/sysprefs.sql
Auto-merging Koha/Library.pm
Patch failed at 0001 Bug 15647: Allow selection of destination email address for print overdue notices

I believe this has been resolved by the AddressForFailedOverdueNotices system preference.