Summary: | alphabetize marc modification pulldowns | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Templates | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | brendan, jonathan.druart |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
marc modification templates
Bug 15669 - alphabetize marc modification templtes [SIGNED-OFF]Bug 15669: Alphabetize marc modification templates Bug 15669 - alphabetize marc modification templates Bug 15669 Alphabetize marc modification templates Bug 15669: Alphabetize marc modification templates Bug 15669: Add a test for GetModificationTemplates |
Created attachment 47310 [details] [review] Bug 15669 - alphabetize marc modification templtes This patch sorts the mdofication templates lists before passing them into templates in the three places they are used tools/batch_record_modification.pl tools/marc_modification.pl tools/stage-marc-import.pl To test: 1 - Add some marc modification templates in a non alpha order (Shoes, Hats, Cats) 2 - visit the three pages above and note the templates are in order added 3 - apply patch 4 - visit the three pages and note correct order 5 - verify all tools continue to work as expected Created attachment 47311 [details] [review] [SIGNED-OFF]Bug 15669: Alphabetize marc modification templates This patch sorts the mdofication templates lists before passing them into templates in the three places they are used tools/batch_record_modification.pl tools/marc_modification.pl tools/stage-marc-import.pl To test: 1 - Add some marc modification templates in a non alpha order (Shoes, Hats, Cats) 2 - visit the three pages above and note the templates are in order added 3 - apply patch 4 - visit the three pages and note correct order 5 - verify all tools continue to work as expected Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Nick, there is another place where they are displayed: tools/stage-marc-import.pl Maybe the best way would be to modify GetModificationTemplates and sort the entries at the DB level (order by clause). Created attachment 48219 [details] [review] Bug 15669 - alphabetize marc modification templates This patch sorts the modification templates when getting them from the database This affects the pages below: tools/batch_record_modification.pl tools/marc_modification.pl tools/stage-marc-import.pl tools/stage-marc-import.pl To test: 1 - Add some marc modification templates in a non alpha order (Shoes, Hats, Cats) 2 - visit the pages above and note the templates are in order added 3 - apply patch 4 - visit the three pages and note correct order 5 - verify all tools continue to work as expected This was my first though, no idea what changed my mind, but I have done it this way now :-) (In reply to Jonathan Druart from comment #3) > Maybe the best way would be to modify GetModificationTemplates and sort the > entries at the DB level (order by clause). Created attachment 48612 [details] [review] Bug 15669 Alphabetize marc modification templates This patch sorts the modification templates when getting them from the database This affects the pages below: tools/batch_record_modification.pl tools/marc_modification.pl tools/stage-marc-import.pl To test: 1 - Add some marc modification templates in a non alpha order (Shoes, Hats, Cats) 2 - visit the pages above and note the templates are in order added 3 - apply patch 4 - visit the three pages and note correct order 5 - verify all tools continue to work as expected Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Created attachment 48615 [details] [review] Bug 15669: Alphabetize marc modification templates This patch sorts the modification templates when getting them from the database This affects the pages below: tools/batch_record_modification.pl tools/marc_modification.pl tools/stage-marc-import.pl To test: 1 - Add some marc modification templates in a non alpha order (Shoes, Hats, Cats) 2 - visit the pages above and note the templates are in order added 3 - apply patch 4 - visit the three pages and note correct order 5 - verify all tools continue to work as expected Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 48616 [details] [review] Bug 15669: Add a test for GetModificationTemplates Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - Should be in the May 2016 Release. Thanks! |
Created attachment 47304 [details] marc modification templates It would be great if all pull downs in Koha were sorted alphabetically, every pull down can get out of hand real fast. That said this report is for the pull down of Marc Modification Templates.