Bug 15686

Summary: Rename "item level holds" circ rule column to "OPAC item level holds"
Product: Koha Reporter: HB-NEKLS <gwilliams>
Component: System AdministrationAssignee: Lisette Scheer <lisettepalouse+koha>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: enhancement    
Priority: P5 - low CC: 1joynelson, gmcharlt, katrin.fischer, lisettepalouse+koha, nick, stephane.delaye
Version: masterKeywords: Academy
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786
Change sponsored?: --- Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
20.05.00
Attachments: Bug 15686 - Rename "item level holds" circ rule column to "OPAC item level holds"
Bug 15686 - Rename "item level holds" circ rule column to "OPAC item level holds"
Bug 15686 - Rename "item level holds" circ rule column to "OPAC item level holds"

Description HB-NEKLS 2016-01-27 23:42:36 UTC
Bug 5786 moved the OPACItemHolds sys pref setting to the Circulation Rules table. However, the naming of the new circ rules column is quite confusing. It is called "Item level holds" which makes it sound like this setting controls the item level holds placing from anywhere in the system (staff and OPAC sides)

Instead, the setting only affects item level hold placing from the OPAC side. 

Should this column then be renamed to "OPAC item level holds"?, so it's not so confusing?
Comment 1 Katrin Fischer 2016-08-28 12:25:52 UTC
Hi George, feel free to submit a patch doing this! :)
Comment 2 delaye 2017-06-23 14:09:46 UTC
In the Circulation Rule, "Item level holds" works only in 'All location'..In the OPAC don't works in th erule of a location.For me it's logic but for the librian, this column in the table is disturbing.
I prefer before with the systeme preference

why this change?...
Comment 3 Katrin Fischer 2020-01-08 23:15:10 UTC
(In reply to delaye from comment #2)
> In the Circulation Rule, "Item level holds" works only in 'All location'..In
> the OPAC don't works in th erule of a location.For me it's logic but for the
> librian, this column in the table is disturbing.
> I prefer before with the systeme preference
> 
> why this change?...

I don't believe this is true (anymore). But it will use the strictest rule if you have multiple items with different itemtypes on one record, so if you have one item with an itemtype that forces item level, it will do that. 

I think renaming is a good idea still.
Comment 4 Lisette Scheer 2020-01-14 16:54:05 UTC
Created attachment 97359 [details] [review]
Bug 15686 - Rename "item level holds" circ rule column to "OPAC item level holds"

This patch changes the column heading on smart-rules.pl to indicate that it only effects item level holds on the OPAC side, rather than the intranet. 
To test: 
1. Go to Administration, circulation and fine rules. 
2. Observe incorrect heading on both the top and bottom of the table. 
3. Apply the patch. 
4. Repeat step 1. 
5. Observe new headings.
Comment 5 Liz Rea 2020-01-14 17:24:44 UTC
Created attachment 97364 [details] [review]
Bug 15686 - Rename "item level holds" circ rule column to "OPAC item level holds"

This patch changes the column heading on smart-rules.pl to indicate that it only effects item level holds on the OPAC side, rather than the intranet.
To test:
1. Go to Administration, circulation and fine rules.
2. Observe incorrect heading on both the top and bottom of the table.
3. Apply the patch.
4. Repeat step 1.
5. Observe new headings.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Comment 6 Katrin Fischer 2020-01-14 21:31:18 UTC
Created attachment 97370 [details] [review]
Bug 15686 - Rename "item level holds" circ rule column to "OPAC item level holds"

This patch changes the column heading on smart-rules.pl to indicate that it only effects item level holds on the OPAC side, rather than the intranet.
To test:
1. Go to Administration, circulation and fine rules.
2. Observe incorrect heading on both the top and bottom of the table.
3. Apply the patch.
4. Repeat step 1.
5. Observe new headings.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Martin Renvoize 2020-01-20 16:34:16 UTC
Nice work everyone!

Pushed to master for 20.05
Comment 8 Joy Nelson 2020-02-01 00:02:53 UTC
Enhancement not backported to 19.11.x branch