Summary: | Syntax errors in misc/translator/xgettext.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Julian Maurice <julian.maurice> |
Component: | Architecture, internals, and plumbing | Assignee: | Julian Maurice <julian.maurice> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | critical | ||
Priority: | P5 - low | CC: | brendan, f.demians, jonathan.druart, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 6679 | ||
Bug Blocks: | |||
Attachments: |
Bug 15687: Fix xgettext.pl syntax errors
Bug 15687: Fix xgettext.pl syntax errors Bug 15687: Fix xgettext.pl syntax errors Bug 15687 [QA Followup] - Tidy sub to remove tab characters |
Description
Julian Maurice
2016-01-28 08:31:36 UTC
Created attachment 47370 [details] [review] Bug 15687: Fix xgettext.pl syntax errors the translate script is broken as well % ./translate update fr-FR Julian, there are some other occurrences in xgettext.pl which certainly need to be fixed. I think that the easiest way is to revert the original patch. Upgrading to critical. (In reply to Jonathan Druart from comment #3) > Julian, there are some other occurrences in xgettext.pl which certainly need > to be fixed. > > I think that the easiest way is to revert the original patch. With the patch, - perl -cw xgettext.pl is OK - ./translate update fr-FR works fine too Why do you think the revert is needed ? s/needed/easiest/ Created attachment 47381 [details] [review] Bug 15687: Fix xgettext.pl syntax errors Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (In reply to Julian Maurice from comment #4) > (In reply to Jonathan Druart from comment #3) > > Julian, there are some other occurrences in xgettext.pl which certainly need > > to be fixed. > > > > I think that the easiest way is to revert the original patch. > > With the patch, > - perl -cw xgettext.pl is OK > - ./translate update fr-FR works fine too > > Why do you think the revert is needed ? Indeed, sorry. Everything is fine with the patch applied. Created attachment 47461 [details] [review] Bug 15687: Fix xgettext.pl syntax errors Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 47462 [details] [review] Bug 15687 [QA Followup] - Tidy sub to remove tab characters Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to Master - Should be in the May 2016 release. Thanks! Patches pushed to 3.22.x, will be in 3.22.3 Patches pushed to 3.20.x, will be in 3.20.9. |