| Summary: | Restart zebra when rotating logfiles | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
| Component: | Packaging | Assignee: | Marcel de Rooy <m.de.rooy> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | brendan, dcook, f.demians, julian.maurice, robin, tomascohen, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 15713: Restart zebra when rotating logfiles
Bug 15713: Restart zebra when rotating logfiles Bug 15713: Restart zebra when rotating logfiles |
||
|
Description
Marcel de Rooy
2016-02-01 12:45:26 UTC
Created attachment 47504 [details] [review] Bug 15713: Restart zebra when rotating logfiles Somehow, it may happen that Zebra keeps writing to the old rotated logfile with extension .log.1. I must add that although I saw that happen (a new log was created and was empty, while Zebra kept writing to log.1 for weeks), I cannot reproduce it every time. By stopping the zebra server in prerotate and starting it again in postrotate, this should not happen at all. In practice, this implies that your Zebra server is restarted once a week. Note: The existing sharedscripts directive makes sure that these actions are not executed for all individual logfiles but once for all matching logfiles (even when running multiple instances). Test plan: [1] Apply the change in koha-common.logrotate to the file /etc/logrotate.d/koha-common. [2] Run logrotate -f /etc/logrotate.conf (forcing a logrotate). [3] Check in zebra-error.log that your zebra server was stopped ('killed by signal 15'). [4] Verify that your Zebra server runs (read: has been restarted). (Do a search..) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Looks good at a glance. Created attachment 47535 [details] [review] Bug 15713: Restart zebra when rotating logfiles Somehow, it may happen that Zebra keeps writing to the old rotated logfile with extension .log.1. I must add that although I saw that happen (a new log was created and was empty, while Zebra kept writing to log.1 for weeks), I cannot reproduce it every time. By stopping the zebra server in prerotate and starting it again in postrotate, this should not happen at all. In practice, this implies that your Zebra server is restarted once a week. Note: The existing sharedscripts directive makes sure that these actions are not executed for all individual logfiles but once for all matching logfiles (even when running multiple instances). Test plan: [1] Apply the change in koha-common.logrotate to the file /etc/logrotate.d/koha-common. [2] Run logrotate -f /etc/logrotate.conf (forcing a logrotate). [3] Check in zebra-error.log that your zebra server was stopped ('killed by signal 15'). [4] Verify that your Zebra server runs (read: has been restarted). (Do a search..) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 47548 [details] [review] Bug 15713: Restart zebra when rotating logfiles Somehow, it may happen that Zebra keeps writing to the old rotated logfile with extension .log.1. I must add that although I saw that happen (a new log was created and was empty, while Zebra kept writing to log.1 for weeks), I cannot reproduce it every time. By stopping the zebra server in prerotate and starting it again in postrotate, this should not happen at all. In practice, this implies that your Zebra server is restarted once a week. Note: The existing sharedscripts directive makes sure that these actions are not executed for all individual logfiles but once for all matching logfiles (even when running multiple instances). Test plan: [1] Apply the change in koha-common.logrotate to the file /etc/logrotate.d/koha-common. [2] Run logrotate -f /etc/logrotate.conf (forcing a logrotate). [3] Check in zebra-error.log that your zebra server was stopped ('killed by signal 15'). [4] Verify that your Zebra server runs (read: has been restarted). (Do a search..) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - Should be in the May 2016 release. Thanks! Patch pushed to 3.22.x, will be in 3.22.6 Pushed to 3.20.x, will be in 3.20.11. |