Summary: | Installer: Step 3 has HTML tag br showing | ||
---|---|---|---|
Product: | Koha | Reporter: | Mark Tompsett <mtompset> |
Component: | Installation and upgrade (web-based installer) | Assignee: | Mark Tompsett <mtompset> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, jonathan.druart, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 13618 | ||
Bug Blocks: | |||
Attachments: |
Bug 15717: Installer: Step 3 has <br /> showing
Bug 15717: Installer: Step 3 has <br /> showing Bug 15717: Installer: Step 3 has <br /> showing |
Description
Mark Tompsett
2016-02-01 19:25:46 UTC
Created attachment 47528 [details] [review] Bug 15717: Installer: Step 3 has <br /> showing The step to install optional/mandatory things is broken with many <br />'s instead of line breaks. TEST PLAN --------- 1) Back up database 2) Drop database 3) Create empty database 4) Run web installer -- Notice that step 3 has ugly <br />'s at the last part of step 3. 5) Apply patch 6) Repeat steps 2-4 -- Notice the <br />'s are now nice line breaks. NOTE: No promises of perfect positioning! 7) Run koha qa test tools. 8) Restore database NOTE: I suspect it has to do with Template::Stash::AutoEscaping from bug 13618. NOTE: I had to cpan2deb Template::Stash::AutoEscaping to get my master to work. Created attachment 47529 [details] [review] Bug 15717: Installer: Step 3 has <br /> showing The step to install optional/mandatory things is broken with many <br />'s instead of line breaks. TEST PLAN --------- 1) Back up database 2) Drop database 3) Create empty database 4) Run web installer -- Notice that step 3 has ugly <br />'s at the last part of step 3. 5) Apply patch 6) Repeat steps 2-4 -- Notice the <br />'s are now nice line breaks. NOTE: No promises of perfect positioning! 7) Run koha qa test tools. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 47536 [details] [review] Bug 15717: Installer: Step 3 has <br /> showing The step to install optional/mandatory things is broken with many <br />'s instead of line breaks. TEST PLAN --------- 1) Back up database 2) Drop database 3) Create empty database 4) Run web installer -- Notice that step 3 has ugly <br />'s at the last part of step 3. 5) Apply patch 6) Repeat steps 2-4 -- Notice the <br />'s are now nice line breaks. NOTE: No promises of perfect positioning! 7) Run koha qa test tools. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Depends on bug 13618, which has been reverted from master. Awesome work all Pushed to master for 18.11 |