Summary: | About page does not display Apache version | ||
---|---|---|---|
Product: | Koha | Reporter: | Marc Véron <veron> |
Component: | About | Assignee: | Marc Véron <veron> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | brendan, f.demians, hector.hecaxmmx, jonathan.druart, julian.maurice, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13486 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 15721: About page does not display Apache version
[SIGNED-OFF]Bug 15721: About page does not display Apache version Bug 15721: (followup) Add apache2ctl to C4::Context::get_versions Bug 15721: About page does not display Apache version Bug 15721: (followup) Add apache2ctl to C4::Context::get_versions Bug 15721: (QA followup) pick the most probable first |
Description
Marc Véron
2016-02-02 10:31:45 UTC
Created attachment 47547 [details] [review] Bug 15721: About page does not display Apache version This patch changes about.pl to get version information from C4::Context where applicable and fixes missing display of the Apache version e.g. for Apache/2.2.22 To test: - Without patch, open about page in staff client - Remember contents of tab 'Server information' (e.g. make a screenshot) - Apply patch - Verify, that the About page displays the same information as before rsp. additionally displays Apache version if it was missing without patch. This only happen in gitfied installations, /home/myuser/kohaclone Created attachment 47562 [details] [review] [SIGNED-OFF]Bug 15721: About page does not display Apache version This patch changes about.pl to get version information from C4::Context where applicable and fixes missing display of the Apache version e.g. for Apache/2.2.22 To test: - Without patch, open about page in staff client - Remember contents of tab 'Server information' (e.g. make a screenshot) - Apply patch - Verify, that the About page displays the same information as before rsp. additionally displays Apache version if it was missing without patch. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described Marc, I have not tested your patch, but looking at commit 16d7ba09f3705e56ae03beda1dd15111f2583de9 Bug 13486: Apache version empty in about page if Apache 2.4 it might be wrong with apache 2.4 Hi Jonathan, I removed the check for versions from about.pl and I use C4::Context::get_versions() instead. So C4::Context::get_versions() would give wrong results? - Or what is precisely the reason to fail the patch? Anyway, it fixes for me the issue on current master and on a 3.22 installation. Marc, On bug 13486, Tomas removed `apache2 -V`, to use `apache2clt -v` instead. Your patch restores the behavior prior to bug 13486: C4::Context::get_versions does not call apache2ctl. Tomas, any ideas what is the best way to fix this one? Hi Jonathan, I think that in that case C4::Context::get_versions should be fixed in a separate bug that blocks this Bug 15271. Note: I do not touch C4::Context::get_versions, but I use it to remove code duplication. Marc Created attachment 48250 [details] [review] Bug 15721: (followup) Add apache2ctl to C4::Context::get_versions See comment #6 I think the followup needs a sign-off. For test plan see comment #2. Still applies on current master. Created attachment 48502 [details] [review] Bug 15721: About page does not display Apache version This patch changes about.pl to get version information from C4::Context where applicable and fixes missing display of the Apache version e.g. for Apache/2.2.22 To test: - Without patch, open about page in staff client - Remember contents of tab 'Server information' (e.g. make a screenshot) - Apply patch - Verify, that the About page displays the same information as before rsp. additionally displays Apache version if it was missing without patch. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> Created attachment 48503 [details] [review] Bug 15721: (followup) Add apache2ctl to C4::Context::get_versions See comment #6 Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> Created attachment 48504 [details] [review] Bug 15721: (QA followup) pick the most probable first Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> Pushed to Master - Should be in the May 2016 Release. Thanks Patches pushed to 3.22.x, will be in 3.22.5 This patch has been pushed to 3.20.x, will be in 3.20.10. |