| Summary: | Saving a new printer profile does not work | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
| Component: | Label/patron card printing | Assignee: | Chris Nighswonger <cnighswonger> |
| Status: | In Discussion --- | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
|
Description
Aleisha Amohia
2016-02-04 01:43:31 UTC
Granted the error trapping here and feedback to the user leaves much to be desired, however, the behavior is as expected. Looking here: http://tinyurl.com/z3t845z will show that what we do is run a parameter check when asked to create a new Profile object. If all required parameters are not passed in, rather than returning a new object, -1 is returned which causes the attempt to invoke the save method to fail. Its old code, and I never go back to adding proper error trapping. It really should not return -1 in any case. In light of that, this bug should probably be closed RESOLVED WORKSFORME and another opened which addresses error trapping in the labels/patroncards code in general. |