Bug 15776

Summary: "Return to where you were before" in sysprefs doesn't work
Product: Koha Reporter: Aleisha Amohia <aleisha>
Component: System AdministrationAssignee: Marc Véron <veron>
Status: CLOSED WONTFIX QA Contact: Marcel de Rooy <m.de.rooy>
Severity: trivial    
Priority: P5 - low CC: gmcharlt, m.de.rooy, veron
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15808
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 15776: "Return to where you were before" in sysprefs doesn't work
[SIGNED-OFF] Bug 15776: "Return to where you were before" in sysprefs doesn't work

Description Aleisha Amohia 2016-02-09 20:23:01 UTC
Go to Admin - System Preferences
Click on any tab except for Acquisitions (since this is the default tab to go to)
Do a search in the sysprefs toolbar with spelling mistakes so that it will return no results and you are taken to the Acquisitions tab
Click the 'Return to where you were before link' in the error message
Notice you stay on the Acquisitions tab, which is not where you were before
Comment 1 Marc Véron 2016-02-10 19:20:43 UTC Comment hidden (obsolete)
Comment 2 Aleisha Amohia 2016-02-10 19:30:47 UTC
Created attachment 47876 [details] [review]
[SIGNED-OFF] Bug 15776: "Return to where you were before" in sysprefs doesn't work

This patch fixes "Return to where you were before" in sysprefs

To test:
- Apply patch
- Go to Admin - System Preferences
- Click on any tab except for Acquisitions (since this is the default tab
  to go to)
- Do a search in the sysprefs toolbar with spelling mistakes so that it
  will return no results and you are taken to the Acquisitions tab
- Click the 'Return to where you were before link' in the error message
- Verify that you are taken back to the correct tab

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Comment 3 Marcel de Rooy 2016-02-12 07:46:36 UTC
Marc,
Returning to where I was before, is actually just the tab where I am already.
Note that it does not work for Local use (another script).
Could you not just remove this link? Just display the alert. Nothing more..
Comment 4 Marc Véron 2016-02-12 08:15:51 UTC
I will file a new bug and mark this as WONTFIX
Comment 5 Marc Véron 2016-02-12 08:21:00 UTC
See Bug 15808